Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icons): fix chart naming scheme, lucide-ize appearance, et cetera #2219

Merged
merged 4 commits into from
Jul 22, 2024
Merged

feat(icons): fix chart naming scheme, lucide-ize appearance, et cetera #2219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e830757
feat(icons): fix chart naming scheme, lucide-ize appearance, add some…
Jun 14, 2024
050d4c6
feat(icons): fix missing SVG code
Jun 14, 2024
855ad3a
feat(icons): fix linting issue
Jun 14, 2024
14568dd
Merge branch 'main' into icon/charts
ericfennis Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions icons/bar-chart-big.json
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions icons/bar-chart-horizontal-big.svg
View file
Open in desktop

This file was deleted.

24 changes: 24 additions & 0 deletions icons/chart-area.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"$schema": "../icon.schema.json",
"contributors": [
"nstokoe"
],
"tags": [

Check notice on line 6 in icons/chart-area.json

View workflow job for this annotation

GitHub Actions / lint-contributors

Contributors have changed! 

Don't add people who have only performed automatic optimizations.

+  "aliases": [
+    {
+      "name": "area-chart",
+      "deprecated": true,
+      "deprecationReason": "alias.name",
+      "toBeRemovedInVersion": "v1.0"
+    }
+  ],
@@ -15,8 +22,0 @@
-  ],
-  "aliases": [
-    {
-      "name": "area-chart",
-      "deprecated": true,
-      "deprecationReason": "alias.name",
-      "toBeRemovedInVersion": "v1.0"
-    }
"statistics",
"analytics",
"diagram",
"graph",
"area"
],
"categories": [
"charts"
],
"aliases": [
{
"name": "area-chart",
"deprecated": true,
"deprecationReason": "alias.name",
"toBeRemovedInVersion": "v1.0"
}
]
}
14 changes: 14 additions & 0 deletions icons/chart-area.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
24 changes: 24 additions & 0 deletions icons/chart-bar-big.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"$schema": "../icon.schema.json",
"contributors": [
"danielbayley",
"karsa-mistmere"
],
"tags": [

Check notice on line 7 in icons/chart-bar-big.json

View workflow job for this annotation

GitHub Actions / lint-contributors

Contributors have changed! 

Don't add people who have only performed automatic optimizations.

+  "aliases": [
+    {
+      "name": "bar-chart-horizontal-big",
+      "deprecated": true,
+      "deprecationReason": "alias.name",
+      "toBeRemovedInVersion": "v1.0"
+    }
+  ],
@@ -15,8 +22,0 @@
-  ],
-  "aliases": [
-    {
-      "name": "bar-chart-horizontal-big",
-      "deprecated": true,
-      "deprecationReason": "alias.name",
-      "toBeRemovedInVersion": "v1.0"
-    }
"statistics",
"analytics",
"diagram",
"graph"
],
"categories": [
"charts"
],
"aliases": [
{
"name": "bar-chart-horizontal-big",
"deprecated": true,
"deprecationReason": "alias.name",
"toBeRemovedInVersion": "v1.0"
}
]
}
6 changes: 3 additions & 3 deletions icons/bar-chart-big.svg → icons/chart-bar-big.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions icons/bar-chart-2.json → icons/chart-bar-decreasing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"$schema": "../icon.schema.json",
"contributors": [
"colebemis",
"ericfennis"
"karsa-mistmere"
],
"tags": [
"statistics",
"analytics",
"diagram",
"graph"
"graph",
"trending down"
],
"categories": [
"charts"
Expand Down
16 changes: 16 additions & 0 deletions icons/chart-bar-decreasing.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion icons/line-chart.json → icons/chart-bar-increasing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"statistics",
"analytics",
"diagram",
"graph"
"graph",
"trending up"
],
"categories": [
"charts"
Expand Down
16 changes: 16 additions & 0 deletions icons/chart-bar-increasing.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 4 additions & 1 deletion icons/bar-chart-horizontal.json → icons/chart-bar-stacked.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@
"statistics",
"analytics",
"diagram",
"graph"
"graph",
"multivariate",
"categorical",
"comparison"
],
"categories": [
"charts"
Expand Down
17 changes: 17 additions & 0 deletions icons/chart-bar-stacked.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
24 changes: 24 additions & 0 deletions icons/chart-bar.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"$schema": "../icon.schema.json",
"contributors": [
"karsa-mistmere",
"danielbayley"
],
"tags": [

Check notice on line 7 in icons/chart-bar.json

View workflow job for this annotation

GitHub Actions / lint-contributors

Contributors have changed! 

Don't add people who have only performed automatic optimizations.

+  "aliases": [
+    {
+      "name": "bar-chart-horizontal",
+      "deprecated": true,
+      "deprecationReason": "alias.name",
+      "toBeRemovedInVersion": "v1.0"
+    }
+  ],
@@ -15,8 +22,0 @@
-  ],
-  "aliases": [
-    {
-      "name": "bar-chart-horizontal",
-      "deprecated": true,
-      "deprecationReason": "alias.name",
-      "toBeRemovedInVersion": "v1.0"
-    }
"statistics",
"analytics",
"diagram",
"graph"
],
"categories": [
"charts"
],
"aliases": [
{
"name": "bar-chart-horizontal",
"deprecated": true,
"deprecationReason": "alias.name",
"toBeRemovedInVersion": "v1.0"
}
]
}
2 changes: 1 addition & 1 deletion icons/bar-chart-horizontal.svg → icons/chart-bar.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions icons/candlestick-chart.json → icons/chart-candlestick.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"$schema": "../icon.schema.json",
"contributors": [
"danielbayley"
],
"tags": [

Check notice on line 6 in icons/chart-candlestick.json

View workflow job for this annotation

GitHub Actions / lint-contributors

Contributors have changed! 

Don't add people who have only performed automatic optimizations.

+  "aliases": [
+    {
+      "name": "candlestick-chart",
+      "deprecated": true,
+      "deprecationReason": "alias.name",
+      "toBeRemovedInVersion": "v1.0"
+    }
+  ],
@@ -29,8 +36,0 @@
-  ],
-  "aliases": [
-    {
-      "name": "candlestick-chart",
-      "deprecated": true,
-      "deprecationReason": "alias.name",
-      "toBeRemovedInVersion": "v1.0"
-    }
"trading",
"trader",
"financial",
Expand All @@ -26,5 +26,13 @@
"categories": [
"charts",
"money"
],
"aliases": [
{
"name": "candlestick-chart",
"deprecated": true,
"deprecationReason": "alias.name",
"toBeRemovedInVersion": "v1.0"
}
]
}
2 changes: 1 addition & 1 deletion icons/candlestick-chart.svg → icons/chart-candlestick.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
24 changes: 24 additions & 0 deletions icons/chart-column-big.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"$schema": "../icon.schema.json",
"contributors": [
"danielbayley",
"karsa-mistmere"
],
"tags": [

Check notice on line 7 in icons/chart-column-big.json

View workflow job for this annotation

GitHub Actions / lint-contributors

Contributors have changed! 

Don't add people who have only performed automatic optimizations.

+  "aliases": [
+    {
+      "name": "bar-chart-big",
+      "deprecated": true,
+      "deprecationReason": "alias.name",
+      "toBeRemovedInVersion": "v1.0"
+    }
+  ],
@@ -15,8 +22,0 @@
-  ],
-  "aliases": [
-    {
-      "name": "bar-chart-big",
-      "deprecated": true,
-      "deprecationReason": "alias.name",
-      "toBeRemovedInVersion": "v1.0"
-    }
"statistics",
"analytics",
"diagram",
"graph"
],
"categories": [
"charts"
],
"aliases": [
{
"name": "bar-chart-big",
"deprecated": true,
"deprecationReason": "alias.name",
"toBeRemovedInVersion": "v1.0"
}
]
}
15 changes: 15 additions & 0 deletions icons/chart-column-big.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions icons/bar-chart-3.json → icons/chart-column-decreasing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"$schema": "../icon.schema.json",
"contributors": [
"karsa-mistmere",
"danielbayley"
"karsa-mistmere"
],
"tags": [
"statistics",
"analytics",
"diagram",
"graph"
"graph",
"trending down"
],
"categories": [
"charts"
Expand Down
6 changes: 3 additions & 3 deletions icons/bar-chart-4.svg → icons/chart-column-decreasing.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
25 changes: 25 additions & 0 deletions icons/chart-column-increasing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"$schema": "../icon.schema.json",
"contributors": [
"karsa-mistmere",
"danielbayley"
],
"tags": [

Check notice on line 7 in icons/chart-column-increasing.json

View workflow job for this annotation

GitHub Actions / lint-contributors

Contributors have changed! 

Don't add people who have only performed automatic optimizations.

+  "aliases": [
+    {
+      "name": "bar-chart-4",
+      "deprecated": true,
+      "deprecationReason": "alias.name",
+      "toBeRemovedInVersion": "v1.0"
+    }
+  ],
@@ -16,8 +23,0 @@
-  ],
-  "aliases": [
-    {
-      "name": "bar-chart-4",
-      "deprecated": true,
-      "deprecationReason": "alias.name",
-      "toBeRemovedInVersion": "v1.0"
-    }
"statistics",
"analytics",
"diagram",
"graph",
"trending up"
],
"categories": [
"charts"
],
"aliases": [
{
"name": "bar-chart-4",
"deprecated": true,
"deprecationReason": "alias.name",
"toBeRemovedInVersion": "v1.0"
}
]
}
16 changes: 16 additions & 0 deletions icons/chart-column-increasing.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 4 additions & 1 deletion icons/bar-chart-4.json → icons/chart-column-stacked.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@
"statistics",
"analytics",
"diagram",
"graph"
"graph",
"multivariate",
"categorical",
"comparison"
],
"categories": [
"charts"
Expand Down
17 changes: 17 additions & 0 deletions icons/chart-column-stacked.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading