Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Crystal 0.36.0 #1398

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Conversation

bcardiff
Copy link
Contributor

A small tweak to #1367 to be usable for 0.36.0

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Thanks!

@jwoertink jwoertink merged commit 059fcd8 into luckyframework:master Jan 25, 2021
@bcardiff
Copy link
Contributor Author

BTW the thing I notice for 0.36 is a spec that will start to fail due to a whitespace

https://github.com/bcardiff/test-ecosystem/runs/1764657336?check_suite_focus=true#step:13:65

# Failures:
# 
#   1) Lucky::HTMLPage empty tags can be called with various arguments
#      Failure/Error: view(&.br).should eq %(<br>)
# 
#        Expected: "<br>"
#             got: "<br> "
# 
#      # spec/lucky/html_page_spec.cr:105
# 
# Finished in 10.08 seconds
# 604 examples, 1 failures, 0 errors, 0 pending

Since it's html I figure is not an issue. I haven't tracked down where that whitespace is coming from.

@jwoertink
Copy link
Member

That's strange 🤔 It's coming from here https://github.com/luckyframework/lucky/blob/master/src/lucky/tags/base_tags.cr#L75 which actually does have that space after it. But I wonder why it would now just start failing....

@jwoertink
Copy link
Member

That spec is here https://github.com/luckyframework/lucky/blob/master/spec/lucky/html_page_spec.cr#L105 Maybe it's just that the spec eq didn't account for spaces at the end before and now it does? Either way, easy fix! I'll open an issue to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants