Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting the type declarations from needs so the nillable ones are las… #993

Merged
merged 4 commits into from
Dec 23, 2019
Merged

Sorting the type declarations from needs so the nillable ones are las… #993

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d85e398
Sorting the type declarations from needs so the nillable ones are las…
jwoertink Dec 23, 2019
05b459a
Account for when a needs has a default value that isn't nilable.
jwoertink Dec 23, 2019
c90ddcc
make sure that type declarations with a default of false and nil are …
jwoertink Dec 23, 2019
de4242f
added a few more needs just to be sure we're covering edge cases. I h…
jwoertink Dec 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spec/lucky/component_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ private class TestComponent < Lucky::BaseComponent
end

private class ComplexTestComponent < Lucky::BaseComponent
needs extra_css : String?
jwoertink marked this conversation as resolved.
Show resolved Hide resolved
needs title : String

def render
Expand Down
3 changes: 2 additions & 1 deletion src/lucky/html_builder.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ module Lucky::HTMLBuilder

macro generate_needy_initializer
{% if !@type.abstract? %}
{% sorted_assigns = ASSIGNS.sort_by { |dec| dec.type.resolve.nilable? ? 1 : 0 } %}
def initialize(
{% for declaration in ASSIGNS %}
{% for declaration in sorted_assigns %}
{% var = declaration.var %}
{% type = declaration.type %}
{% value = declaration.value %}
Expand Down