Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catching urllib3 exception #2294

Merged
merged 2 commits into from
Jul 21, 2022
Merged

catching urllib3 exception #2294

merged 2 commits into from
Jul 21, 2022

Conversation

abidwael
Copy link
Contributor

Changed exception catching in ludwig.utils.fs_utils.get_bytes_obj_from_path from except requests.exceptions.RequestException as e to except Exception as e.

Used Exception instead of a urllib3 specific base exception because urllib3 doesn't have one.

@github-actions
Copy link

github-actions bot commented Jul 20, 2022 •
edited
Loading

Unit Test Results

       6 files  +    1         6 suites  +1   2h 29m 13s ⏱️ + 33m 25s
2 936 tests ±    0  2 887 ✔️ ±    0    49 💤 ±  0  0 ❌ ±0 
8 808 runs  +125  8 625 ✔️ +104  183 💤 +21  0 ❌ ±0 

Results for commit 5f85adf. ± Comparison against base commit e4189b8.

♻️ This comment has been updated with latest results.

@geoffreyangus
Copy link
Contributor

LGTM. Is there a test we can add to ensure that this behaves as expected?

@abidwael abidwael merged commit 217557a into master Jul 21, 2022
@abidwael abidwael deleted the urllib3-catch-exception branch July 21, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreyangus geoffreyangus geoffreyangus approved these changes

@justinxzhao justinxzhao justinxzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abidwael @geoffreyangus @justinxzhao