Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catching urllib3 exception #2294

Merged
merged 2 commits into from
Jul 21, 2022
Merged

catching urllib3 exception #2294

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2852fa0
catching urllib3 exception
Jul 20, 2022
5f85adf
removed `requests` import
Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ludwig/utils/fs_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
import certifi
import fsspec
import h5py
import requests
import urllib3
from filelock import FileLock
from fsspec.core import split_protocol
Expand Down Expand Up @@ -77,7 +76,7 @@ def get_bytes_obj_from_path(path: str) -> Optional[bytes]:
if is_http(path):
try:
return get_bytes_obj_from_http_path(path)
except requests.exceptions.RequestException as e:
except Exception as e:
logging.warning(e)
return None
else:
Expand Down