Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Readme Generation #135

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Automatic Readme Generation #135

merged 3 commits into from
Apr 5, 2024

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented Apr 5, 2024

We want to update the README even when NPM fails.

Maybe even have a 'knob' to update it at will.

Also update actions to Node20.

Fixes: #117

@Finii Finii added the CI label Apr 5, 2024
@Finii Finii requested a review from hasecilu April 5, 2024 09:27
Copy link
Collaborator

@hasecilu hasecilu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[why]
The Node 16 based actions are deprecated and should not be used anymore.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
We want to update the README even when NPM fails.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
The workflow is more robust when we fetch before we commit new stuff (to
be safe against in-the-meanwhile changes to the repo).

The option to not-fetch has been copied over from another project (Nerd
Fonts) where it made sense because fetching takes a long time due to its
repo size.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii force-pushed the feature/readme-generation branch from 92e0da6 to 6bb6c51 Compare April 5, 2024 20:30
@Finii Finii merged commit b99804d into master Apr 5, 2024
@Finii
Copy link
Collaborator Author

Finii commented Apr 5, 2024

Oh my....

forgot to change name, and stumble about my own safeguard....

image

@Finii
Copy link
Collaborator Author

Finii commented Apr 5, 2024

Fixed via 2c9c471

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No automatic README update after release
3 participants