Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project status? #2

Open
Envek opened this issue May 4, 2020 · 8 comments
Open

Project status? #2

Envek opened this issue May 4, 2020 · 8 comments

Comments

@Envek
Copy link
Contributor

Envek commented May 4, 2020

Hi! Thank you very much for sharing your exporter of Faktory metrics!

Do you have plans on its further development or maintenance?

For example I can see one active fork here: praekeltfoundation/faktory_exporter. Do you want to pull their enhancements to your repo?

If I send you some pull requests on top of these enhancements, will you receive them?

Thank you in advance!

@lukasmalkmus
Copy link
Owner

I won't do any more work by myself because I'm not a Faktory user at the moment. Is Faktory not exporting metrics by itself?

But yes, I'll continue to merge PRs and maintain the Repository if there are use cases for this.

@Envek
Copy link
Contributor Author

Envek commented May 8, 2020

@mperham planned to add it last year here: contribsys/faktory#206 (comment)

But as far as I can see there is still no built-in Prometheus support in Faktory.

For now I can create pull request with commits by @bearnard (support for queues and retry set sizes) and then duplicate my pull requests from their fork here.

Thank you very much for creating this exporter!

@mperham
Copy link

mperham commented May 8, 2020

Sorry, I totally dropped this. My brain: "There's no open issue for it so it doesn't exist anymore". Add a specific issue for this and I'll get to it.

@Envek
Copy link
Contributor Author

Envek commented May 8, 2020

@mperham, may be you want to take care over this community Prometheus exporter for Faktory?

With folk's and my patches it totally works and it would be great if it would be moved to contribsys organization and would become official exporter 😃

@lukasmalkmus, what do you think?

@mperham
Copy link

mperham commented May 8, 2020

Native metrics support is a Pro feature, I can't include it in OSS so I can't take this repo.

@bearnard
Copy link
Contributor

bearnard commented May 8, 2020

@mperham planned to add it last year here: contribsys/faktory#206 (comment)

But as far as I can see there is still no built-in Prometheus support in Faktory.

For now I can create pull request with commits by @bearnard (support for queues and retry set sizes) and then duplicate my pull requests from their fork here.

Thank you very much for creating this exporter!

@Envek Apologies for the delay...
Feel free to push those queue metrics additions upstream.

lukasmalkmus pushed a commit that referenced this issue May 13, 2020
@MRigal
Copy link
Contributor

MRigal commented Jun 27, 2024

As a non-go developer, I was not able to use the repo in the current state, even pinning go to 1.19, also having troubles with the Dockerfile...
Thus I've made this small Python Exporter which was inspired by your work Lukas: https://github.com/prospect-server/faktory-prometheus-exporter

@lukasmalkmus
Copy link
Owner

lukasmalkmus commented Jun 28, 2024

@MRigal Unfortunately, I don't really have the capacity to maintain this project, atm. And since I'm not an active Faktory user at the moment, as well, the motivation to do so is also low :/

But I appreciate you bringing up your own exporter. If you want to, feel free to open a PR that adds a deprecation notice to the README and link your exporter. That way, people might be more likely to stumble across your work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants