Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set URL to Faktory instance via FAKTORY_URL env variable #3

Closed
wants to merge 1 commit into from
Closed

Conversation

Envek
Copy link

@Envek Envek commented Apr 30, 2020

Context

In containerized world (especially in Kubernetes) it is very common pattern to pass secret values via environment variables without exposing them in command line arguments or elsewhere.

What's inside

Ability to specify URL to faktory instance (including password) via FAKTORY_URL environment variable.

Kubernetes usage

# Somewhere deep in StatefulSet declaration
        - name: metrics-exporter
          image: "praekeltfoundation/faktory_exporter:notyetreleased"
          imagePullPolicy: Always
          env:
            - name: FAKTORY_PASSWORD
              valueFrom:
                secretKeyRef:
                  name: faktory
                  key: password
            - name: FAKTORY_URL
              value: tcp://:$(FAKTORY_PASSWORD)@localhost:7419

@Envek
Copy link
Author

Envek commented May 4, 2020

By the way, @praekeltfoundation, @bearnard, do you want to send your current enhancements to the upstream repo or take over project maintenance? See lukasmalkmus#2

I would be happy to send some more minor pull requests, either to you or upstream.

Sorry, I can't create new issue in your fork so asking it here.

@lukasmalkmus
Copy link

Feel free to ping me if there is anything I can help with 👍

@Envek
Copy link
Author

Envek commented May 14, 2020

Merged into upstream in lukasmalkmus#4

@Envek Envek closed this May 14, 2020
@Envek Envek deleted the feature/env-vars branch May 14, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants