Parse JSON message #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenGregory
commented
Feb 7, 2018
|
|
||
| const ws = new Sockette('ws://localhost:8080', { | ||
| onmessage: e => { | ||
| mockServer.stop(); |
There was a problem hiding this comment.
This is clean-up that needs to be done before creating a new MockServer. I'd rather put it somewhere else to ensure that it is always called, but could not think of anywhere else to put it as tape does not have any clean-up methods.
|
Hi there~! I'm sorry, but I don't really want this feature in here. 🙈 IMO, it totally belongs as part of your
That said, the testing looks great!!! I'd be stoked if you created a new PR that introduced testing for the existing library. Thank you so much, hope you understand 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #4 , I wanted to similarly add parsing of JSON strings automatically.