-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 New Crowdin updates #1335
🌐 New Crowdin updates #1335
Conversation
[ci skip]
[ci skip]
[ci skip]
[ci skip]
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
WalkthroughThis pull request introduces new localization strings to enhance user interface messages related to user profile management and file uploads across multiple languages, including English, Dutch, Hungarian, Basque, Finnish, and Swedish. It includes entries for actions such as removing an avatar, indicating feature availability, and providing descriptions for uploading profile pictures with restrictions on file types and sizes. Additionally, new messages related to polls and event reservations are added to the email localization files, improving user guidance for sharing participant links. Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- apps/web/public/locales/en/app.json (1 hunks)
- apps/web/public/locales/nl/app.json (1 hunks)
- packages/emails/locales/en/emails.json (1 hunks)
- packages/emails/locales/nl/emails.json (1 hunks)
Additional comments not posted (8)
packages/emails/locales/en/emails.json (1)
49-49
: New localization entry added successfully.The addition of
"newPoll_preview": "Share your participant link to start collecting responses."
enhances the application's functionality by providing clear guidance for poll sharing. The JSON syntax is correct, and the entry fits well within the existing structure.packages/emails/locales/nl/emails.json (1)
49-49
: New localization entry added successfully.The addition of
"newPoll_preview": "Deel de uitnodigingslink om te beginnen met het verzamelen van reacties."
enhances the application's functionality by providing clear guidance for poll sharing in Dutch. The JSON syntax is correct, and the entry fits well within the existing structure.apps/web/public/locales/en/app.json (1)
276-285
: New localization entries added successfully.The addition of multiple key-value pairs related to user profile management and file uploads enhances the application's functionality by providing clear guidance and feedback. The JSON syntax is correct, and the entries fit well within the existing structure.
apps/web/public/locales/nl/app.json (5)
277-277
: New localization string for removing an avatarThe addition of the
"removeAvatar": "Verwijderen"
string is clear and concise. It fits well within the context of user profile management.
278-279
: New localization strings for unavailable featuresThe strings
"featureNotAvailable": "Functie niet beschikbaar"
and"featureNotAvailableDescription": "Deze functie vereist dat objectopslag is ingeschakeld."
are well-phrased and provide clear information about feature availability and requirements.
280-281
: New localization strings for uploading profile picturesThe strings
"uploadProfilePicture": "Uploaden"
and"profilePictureDescription": "Tot 2MB, JPG of PNG"
are correctly added. They provide essential information about the file upload requirements, which enhances user understanding and compliance.
282-283
: New localization strings for invalid file typesThe strings
"invalidFileType": "Ongeldig bestandstype"
and"invalidFileTypeDescription": "Upload een JPG- of PNG-bestand."
effectively communicate the restrictions on file types, which is crucial for preventing user errors during file uploads.
284-285
: New localization strings for file size limitationsThe strings
"fileTooLarge": "Bestand te groot"
and"fileTooLargeDescription": "Upload een bestand kleiner dan 2MB."
are clear and directly address the common issue of file size limitations. This addition will help users understand why their uploads may fail, improving the user experience.
[ci skip]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- apps/web/public/locales/hu/app.json (1 hunks)
- packages/emails/locales/hu/emails.json (1 hunks)
Additional comments not posted (2)
packages/emails/locales/hu/emails.json (1)
49-49
: Approved: New localization key added.The addition of
"newPoll_preview": "Oszd meg a résztvevői linked, hogy elkezdhess a válaszok gyűjteni."
is correctly formatted and follows the JSON syntax. This key provides a clear instruction for users, enhancing the email functionality related to polls.apps/web/public/locales/hu/app.json (1)
277-285
: Approved: New localization keys added for profile management and file uploads.The new keys added for managing avatars, handling file uploads, and providing user feedback on errors are correctly formatted and follow JSON syntax. These additions enhance the user interface by providing clearer instructions and error messages, improving the overall user experience.
[ci skip]
[ci skip]
[ci skip]
[ci skip]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- apps/web/public/locales/eu/app.json (1 hunks)
- apps/web/public/locales/fi/app.json (1 hunks)
- apps/web/public/locales/sv/app.json (1 hunks)
- packages/emails/locales/eu/emails.json (1 hunks)
- packages/emails/locales/fi/emails.json (1 hunks)
- packages/emails/locales/sv/emails.json (1 hunks)
Additional comments not posted (31)
packages/emails/locales/eu/emails.json (6)
10-10
: Check HTML and placeholder usage.The use of HTML tags and placeholders appears consistent with other keys in the file. Ensure that the rendering of these tags is supported in the email templates where this string will be used.
11-11
: Preview message is clear and concise.The addition of this preview message enhances the clarity of the reservation process for users.
12-12
: Confirm heading consistency.The heading is identical to the preview text. Confirm that this repetition is intentional and aligns with the overall design of the email templates.
13-13
: Informative content about event invitation.This key adds valuable information for the recipient by indicating that an event invitation is attached.
14-14
: Effective use of placeholders in subject line.The subject line effectively uses placeholders to personalize the email, enhancing the recipient's experience.
15-15
: Login button label correctly localized.The label for the login button is appropriately localized, including a placeholder for the domain, which enhances the adaptability of the message across different domains.
packages/emails/locales/fi/emails.json (1)
49-49
: Clear and functional preview message for polling.The addition of this preview message clearly communicates the intended action to users, enhancing the functionality of the polling feature.
packages/emails/locales/sv/emails.json (1)
49-49
: Clear and functional preview message for polling.The addition of this preview message clearly communicates the intended action to users, enhancing the functionality of the polling feature.
apps/web/public/locales/sv/app.json (5)
276-276
: Translation Approved: "uploadProfilePicture"The Swedish translation for "uploadProfilePicture" is correctly implemented as "Ladda upp".
278-278
: Translation Approved: "profilePictureDescription"The description for profile picture requirements in Swedish is accurately translated and clearly states the restrictions.
279-279
: Translation Approved: "invalidFileType"The error message for an invalid file type is correctly translated to Swedish as "Ogiltig filtyp".
280-280
: Translation Approved: "invalidFileTypeDescription"The description for acceptable file types is correctly translated to Swedish, providing clear instructions to the user.
281-281
: Translation Approved: "fileTooLargeDescription"The error message for a file that is too large is accurately translated to Swedish, clearly stating the maximum file size.
apps/web/public/locales/fi/app.json (9)
277-277
: Translation Approved: "removeAvatar"The Finnish translation for "removeAvatar" is correctly implemented as "Poista".
278-278
: Translation Approved: "featureNotAvailable"The notification message for an unavailable feature is accurately translated to Finnish as "Ominaisuus ei ole saatavilla".
279-279
: Translation Approved: "featureNotAvailableDescription"The description explaining why a feature is not available is correctly translated to Finnish, providing clear and specific information.
280-280
: Translation Approved: "uploadProfilePicture"The Finnish translation for "uploadProfilePicture" is correctly implemented as "Lataa".
281-281
: Translation Approved: "profilePictureDescription"The description for profile picture requirements in Finnish is accurately translated and clearly states the restrictions.
282-282
: Translation Approved: "invalidFileType"The error message for an invalid file type is correctly translated to Finnish as "Tiedostomuoto ei kelpaa".
283-283
: Translation Approved: "invalidFileTypeDescription"The description for acceptable file types is correctly translated to Finnish, providing clear instructions to the user.
284-284
: Translation Approved: "fileTooLarge"The error message for a file that is too large is accurately translated to Finnish as "Tiedosto on liian suuri".
285-285
: Translation Approved: "fileTooLargeDescription"The error message for a file that is too large is accurately translated to Finnish, clearly stating the maximum file size.
apps/web/public/locales/eu/app.json (9)
277-277
: Translation Approved: "removeAvatar"The Basque translation for "removeAvatar" is correctly implemented as "Kendu".
278-278
: Translation Approved: "featureNotAvailable"The notification message for an unavailable feature is accurately translated to Basque as "Funtzioa ez dago erabilgarri".
279-279
: Translation Approved: "featureNotAvailableDescription"The description explaining why a feature is not available is correctly translated to Basque, providing clear and specific information.
280-280
: Translation Approved: "uploadProfilePicture"The Basque translation for "uploadProfilePicture" is correctly implemented as "Igo".
281-281
: Translation Approved: "profilePictureDescription"The description for profile picture requirements in Basque is accurately translated and clearly states the restrictions.
282-282
: Translation Approved: "invalidFileType"The error message for an invalid file type is correctly translated to Basque as "Fitxategi mota baliogabea".
283-283
: Translation Approved: "invalidFileTypeDescription"The description for acceptable file types is correctly translated to Basque, providing clear instructions to the user.
284-284
: Translation Approved: "fileTooLarge"The error message for a file that is too large is accurately translated to Basque as "Fitxategi handiegia".
285-285
: Translation Approved: "fileTooLargeDescription"The error message for a file that is too large is accurately translated to Basque, clearly stating the maximum file size.
[ci skip]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/emails/locales/eu/emails.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/emails/locales/eu/emails.json
Summary by CodeRabbit
New Features
Bug Fixes