Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 New Crowdin updates #1347

Merged
merged 6 commits into from
Sep 15, 2024
Merged

🌐 New Crowdin updates #1347

merged 6 commits into from
Sep 15, 2024

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented Sep 14, 2024

Summary by CodeRabbit

  • New Features

    • Added localization support for Rallly as an alternative to When2Meet, including promotional content and descriptions in both English and French.
    • Improved user interface with new French translations for profile picture management features, including upload instructions and error messages.
  • Bug Fixes

    • No functionality changes; purely a localization adjustment.

Copy link

vercel bot commented Sep 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
app ⬜️ Ignored (Inspect) Visit Preview Sep 14, 2024 6:34pm
landing ⬜️ Ignored (Inspect) Visit Preview Sep 14, 2024 6:34pm

Copy link
Contributor

coderabbitai bot commented Sep 14, 2024

Walkthrough

The pull request introduces several updates to the localization files for both English and French, adding new key-value pairs that enhance the application's ability to present alternative references for the "When2Meet" feature. Additionally, it includes new metadata and descriptions promoting Rallly as a superior scheduling tool. The changes expand the localization capabilities without altering existing functionality.

Changes

File Path Change Summary
.../locales/en/common.json Added "when2MeetAlternative": "When2Meet Alternative"
.../locales/en/home.json Added metadata and descriptions promoting Rallly as an alternative to When2Meet.
.../locales/fr/common.json Added "when2MeetAlternative": "Alternative à When2Meet"
.../locales/fr/home.json Added metadata and descriptions promoting Rallly as an alternative to When2Meet.
.../locales/fr/app.json Added localization strings for profile picture management, including upload and error messages.

Possibly related PRs

  • 🌐 New Crowdin updates #1152: Modifies the French localization file common.json with a new key-value pair for "status," related to the main PR's updates.
  • 🌐 New Crowdin updates #1163: Adds a new key-value pair for "status" in the English common.json, aligning with the localization updates in the main PR.
  • 🌐 New Crowdin updates #1176: Introduces a new key-value pair for "status" in the German common.json, indicating consistent updates across multiple languages.
  • 🌐 New Crowdin updates #1199: Adds a new key-value pair for "status" in the Basque common.json, reflecting similar localization enhancements seen in the main PR.

🐰 In the meadow of code, where bunnies convene,
New phrases emerge, bright and serene.
"When2Meet Alternative," a name to embrace,
With Rallly's charm, it finds its place.
Hopping through changes, we cheer with delight,
For clearer paths make our meetings just right! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
apps/landing/public/locales/en/home.json (1)

39-43: LGTM! Consider optimizing the meta title and description for better SEO.

The new entries are syntactically correct and effectively convey Rallly's advantages over When2Meet. The content is grammatically sound and focused.

To further improve the SEO impact, consider the following suggestions for the meta title and description:

  • Meta Title: Include the main keyword "When2Meet Alternative" closer to the beginning of the title for better keyword prominence. For example:

    • "When2Meet Alternative - Rallly: The Best Free Scheduling Tool"
  • Meta Description: Aim for a description length of around 150-160 characters. Include the main keyword and succinctly summarize Rallly's key benefits. For example:

    • "Looking for the best free When2Meet alternative? Rallly offers easy, professional meeting polls with no ads. Create a poll in seconds, no login required!"

These optimizations can help improve the visibility and click-through rate from search engine results.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9fb1f02 and 3497207.

Files selected for processing (5)
  • apps/landing/public/locales/en/common.json (1 hunks)
  • apps/landing/public/locales/en/home.json (1 hunks)
  • apps/landing/public/locales/fr/common.json (1 hunks)
  • apps/landing/public/locales/fr/home.json (1 hunks)
  • apps/web/public/locales/fr/app.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • apps/landing/public/locales/en/common.json
Additional comments not posted (15)
apps/landing/public/locales/fr/common.json (1)

27-28: LGTM!

The addition of the new key-value pair "when2MeetAlternative": "Alternative à When2Meet" is consistent with the localization file's purpose. The translation seems accurate and appropriate for the key. The JSON syntax is valid, and the change is unlikely to affect any existing functionality or logic.

apps/landing/public/locales/fr/home.json (5)

39-39: LGTM!

The new key-value pair for the self-hosting blog is correctly formatted and the French translation seems appropriate.


40-40: LGTM!

The new key-value pair for the When2Meet alternative meta title is correctly formatted and the French translation seems appropriate. It aligns well with the PR objective of promoting Rallly as a When2Meet alternative.


41-41: LGTM!

The new key-value pair for the When2Meet alternative meta description is correctly formatted and the French translation seems appropriate. It effectively promotes Rallly's ease of use and free pricing as advantages over When2Meet, aligning with the PR objectives.


42-42: LGTM!

The new key-value pair for the question asking if the user is still using When2Meet is correctly formatted and the French translation seems appropriate. The phrasing effectively encourages the user to consider switching to Rallly, aligning with the PR objectives.


43-43: LGTM!

The new key-value pair for the description promoting Rallly's free and ad-free meeting polls is correctly formatted and the French translation seems appropriate. It effectively highlights Rallly's advantages of being free and providing professional ad-free polls, aligning with the PR objectives.

apps/web/public/locales/fr/app.json (9)

277-277: LGTM!

The localization string for removing an avatar is properly formatted and the French translation is accurate.


278-278: LGTM!

The localization string for uploading a profile picture is properly formatted and the French translation is accurate.


279-279: LGTM!

The localization string for the profile picture description is properly formatted and the French translation accurately conveys the file type and size restrictions.


280-280: LGTM!

The localization string for an invalid file type is properly formatted and the French translation is accurate.


281-281: LGTM!

The localization string for the invalid file type description is properly formatted and the French translation accurately provides instructions to upload a JPG or PNG file.


282-282: LGTM!

The localization string for a file being too large is properly formatted and the French translation is accurate.


283-283: LGTM!

The localization string for the file too large description is properly formatted and the French translation accurately provides instructions to upload a file smaller than 2 MB.


284-284: LGTM!

The localization string for a picture upload failure is properly formatted and the French translation is accurate.


285-285: LGTM!

The localization string for the picture upload failure description is properly formatted and the French translation accurately provides instructions to try uploading the picture again later due to an error.

@lukevella lukevella enabled auto-merge (squash) September 15, 2024 09:41
@lukevella lukevella disabled auto-merge September 15, 2024 09:43
@lukevella lukevella merged commit 35d2058 into main Sep 15, 2024
3 checks passed
@lukevella lukevella deleted the l10n_main branch September 15, 2024 09:43
This was referenced Sep 15, 2024
This was referenced Sep 30, 2024
This was referenced Oct 30, 2024
@coderabbitai coderabbitai bot mentioned this pull request Nov 15, 2024
This was referenced Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant