Jordan/1502 page proposal #1531
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1531 +/- ##
===========================================
+ Coverage 96.41% 96.45% +0.04%
===========================================
Files 97 98 +1
Lines 1811 1833 +22
Branches 86 91 +5
===========================================
+ Hits 1746 1768 +22
Misses 55 55
Partials 10 10
|
| return `Voting for this proposal is open` | ||
|
|
||
| if (this.proposal.proposal_status === `Pending`) | ||
| return `Deposits are open for this proposal` |
There was a problem hiding this comment.
Deposits are always open as long as the proposal is open (i.e you can also deposit when the proposal is Active), in this case the proposal is Pending because it hasn't met the minimum deposit
There was a problem hiding this comment.
why would a user deposit if a proposal has received enough to open voting?
There was a problem hiding this comment.
I also said that... But you can ask @sunnya97
There was a problem hiding this comment.
we'll see what sunny says, but i don't think we should block on this.
| @@ -94,6 +94,12 @@ export default { | |||
| tooltip: `The title of the proposal`, | |||
| class: `proposal_title` | |||
| }, | |||
| { | |||
| title: `Submitted Block`, | |||
There was a problem hiding this comment.
sorting by proposal id is the same
There was a problem hiding this comment.
true, but i added a column for submit block instead. do you think showing ID as its own column would be better?
| <p> | ||
| Status: Passed | ||
| Proposal description… |
There was a problem hiding this comment.
Add the ... only if the length is > 100
There was a problem hiding this comment.
smart! thanks @fedekunze
| // }, | ||
|
|
||
| { | ||
| path: `/governance/:proposalId`, |
There was a problem hiding this comment.
I'd change this to
| path: `/governance/:proposalId`, | |
| path: `/governance/proposals/:proposalId`, |
| Available Steak | ||
| </h3> | ||
| <h2> | ||
| 0.0000… |
There was a problem hiding this comment.
is this a description ? why does it have the ... ?
There was a problem hiding this comment.
this is how we show numbers in the balance header!
| Yes | ||
| </dt> | ||
| <dd> | ||
| 500 / 0% |
| No | ||
| </dt> | ||
| <dd> | ||
| 25 / 0% |
| No with Veto | ||
| </dt> | ||
| <dd> | ||
| 10 / 0% |
| Abstain | ||
| </dt> | ||
| <dd> | ||
| 56 / 0% |
| Total Steak | ||
| </h3> | ||
| <h2> | ||
| 0.0000… |
| statusColor() { | ||
| if (this.proposal.proposal_status === `Rejected`) return `red` | ||
| else if (this.proposal.proposal_status === `Passed`) return `green` | ||
| status() { |
There was a problem hiding this comment.
does this cover all the cases / is this true?
Closes #1502
Description:
implemented page proposal component and included some nice upgrades to proposals index and a couple of other places.
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer