jbibla+fedekunze/1501 Modal Vote #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
changed the title
…la+fedekunze/1501-proposal-voting Merge develop
Codecov Report
@@ Coverage Diff @@
## develop #1541 +/- ##
===========================================
+ Coverage 96.45% 96.52% +0.07%
===========================================
Files 98 99 +1
Lines 1833 1872 +39
Branches 91 92 +1
===========================================
+ Hits 1768 1807 +39
Misses 55 55
Partials 10 10
|
fedekunze
commented
Nov 9, 2018
faboweb
reviewed
Nov 12, 2018
faboweb
reviewed
Nov 12, 2018
faboweb
reviewed
Nov 12, 2018
faboweb
reviewed
Nov 12, 2018
faboweb
reviewed
Nov 12, 2018
faboweb
reviewed
Nov 12, 2018
faboweb
reviewed
Nov 12, 2018
faboweb
reviewed
Nov 12, 2018
|
|
||
| describe(`Modal onVote`, () => { | ||
| it(`enables voting if the proposal is Active`, () => { | ||
| let status = { button: `vote` } |
There was a problem hiding this comment.
just thinking: status seems to be a complex object that doesn't seem self explanatory. Maybe we could split the object in a refactor.
faboweb
reviewed
Nov 12, 2018
| proposal, | ||
| status | ||
| } | ||
| describe(`without magic`, () => { |
faboweb
reviewed
Nov 12, 2018
| it(`fetches all governance proposals`, async () => { | ||
| let proposals = lcdClientMock.state.proposals | ||
| let proposalsRes = await client.getProposals() | ||
| expect(proposalsRes).toBeDefined() |
faboweb
reviewed
Nov 12, 2018
fedekunze
changed the title
faboweb
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends #1531
Closes #1501
Description:
TODO:
Link to explain the types of proposals❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer