Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fedekunze/1748-display gov parameters tab #1750

Merged
merged 3 commits into from
Dec 17, 2018
Merged

fedekunze/1748-display gov parameters tab #1750

merged 3 commits into from
Dec 17, 2018

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Dec 14, 2018 •
edited
Loading

Closes #1748

Description:

screen shot 2018-12-14 at 4 57 14 pm

❤️ Thank you!

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #1750 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1750   +/-   ##
=======================================
  Coverage     97.7%   97.7%           
=======================================
  Files          102     102           
  Lines         2096    2096           
  Branches        93      93           
=======================================
  Hits          2048    2048           
  Misses          39      39           
  Partials         9       9
Impacted Files Coverage Δ
.../renderer/components/governance/PageGovernance.vue 100% <ø> (ø) ⬆️

@codecov
Copy link

codecov bot commented Dec 14, 2018 •
edited
Loading

Codecov Report

Merging #1750 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1750   +/-   ##
=======================================
  Coverage     97.7%   97.7%           
=======================================
  Files          102     102           
  Lines         2096    2096           
  Branches        93      93           
=======================================
  Hits          2048    2048           
  Misses          39      39           
  Partials         9       9
Impacted Files Coverage Δ
.../renderer/components/governance/PageGovernance.vue 100% <ø> (ø) ⬆️

sabau
sabau previously approved these changes Dec 15, 2018
View reviewed changes
Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fedekunze fedekunze mentioned this pull request Dec 16, 2018
Closed
@faboweb faboweb merged commit 9634d32 into develop Dec 17, 2018
@faboweb faboweb deleted the fedekunze/1748-gov-tab-params branch December 17, 2018 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faboweb faboweb faboweb approved these changes

@sabau sabau sabau left review comments

@nylira nylira Awaiting requested review from nylira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable the tab for governance parameters
3 participants
@fedekunze @sabau @faboweb