Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedekunze/1748-display gov parameters tab #1750

Merged
merged 3 commits into from
Dec 17, 2018
Merged

fedekunze/1748-display gov parameters tab #1750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35a2a63
display tab proposal
Dec 14, 2018
531ed4a
CHANGELOG
Dec 14, 2018
1dc20f3
Merge branch 'develop' into fedekunze/1748-gov-tab-params
fedekunze Dec 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Added compatibility to Gaia/SDK version 0.28.0-rc2 @faboweb
- [\#1673](https://github.com/cosmos/voyager/issues/1673) Documentation and single command to run one or all tests with fallback for end to end test @sabau
- [\#1683](https://github.com/cosmos/voyager/issues/1683) Governance: block voting twice for the same option @sabau
- [\#1748](https://github.com/cosmos/voyager/issues/1748) display governance parameters on tab @fedekunze
- [\#1660](https://github.com/cosmos/voyager/issues/1660) Add parameters and pool to store @fedekunze

### Changed
Expand Down
9 changes: 4 additions & 5 deletions app/src/renderer/components/governance/PageGovernance.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,11 @@ export default {
{
displayName: `Proposals`,
pathName: `Proposals`
},
{
displayName: `Parameters`,
pathName: `Governance Parameters`
}
// TODO uncomment when updated to latest SDK
// {
// displayName: `Parameters`,
// pathName: `Governance Parameters`
// }
],
showModalPropose: false
}),
Expand Down
6 changes: 6 additions & 0 deletions test/unit/specs/components/governance/__snapshots__/PageGovernance.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ exports[`PageGovernance disables proposal creation if not connected 1`] = `
<div class=\\"tab\\">
<a href=\\"#/governance/proposals\\" class=\\"\\">Proposals</a>
</div>
<div class=\\"tab\\">
<a href=\\"#/governance/governance-parameters\\" class=\\"\\">Parameters</a>
</div>
</div>
<button class=\\"tm-btn\\" id=\\"propose-btn\\" disabled=\\"disabled\\"><span class=\\"tm-btn__container tm-btn--primary\\">
<!---->
Expand Down Expand Up @@ -177,6 +180,9 @@ exports[`PageGovernance has the expected html structure 1`] = `
<div class=\\"tab\\">
<a href=\\"#/governance/proposals\\" class=\\"\\">Proposals</a>
</div>
<div class=\\"tab\\">
<a href=\\"#/governance/governance-parameters\\" class=\\"\\">Parameters</a>
</div>
</div>
<button class=\\"tm-btn\\" id=\\"propose-btn\\"><span class=\\"tm-btn__container tm-btn--primary\\">
<!---->
Expand Down