Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/1791 fix voyager init #1794

Merged
merged 5 commits into from
Jan 4, 2019
Merged

Fabo/1791 fix voyager init #1794

merged 5 commits into from
Jan 4, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Jan 3, 2019

Closes #1791

Description:

Copying folders for downloaded testnets may lead to copy loops of folders into folders etc.
Cherrypicking only the needed files seems safer here

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@faboweb faboweb requested a review from nylira as a code owner January 3, 2019 20:17
@faboweb faboweb mentioned this pull request Jan 4, 2019
@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #1794 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1794      +/-   ##
===========================================
+ Coverage    95.07%   95.07%   +<.01%     
===========================================
  Files          122      122              
  Lines         2982     2984       +2     
  Branches       128      128              
===========================================
+ Hits          2835     2837       +2     
  Misses         137      137              
  Partials        10       10
Impacted Files Coverage Δ
app/src/main/index.js 76.15% <100%> (+0.15%) ⬆️

Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@sabau sabau merged commit 97a2d98 into develop Jan 4, 2019
@sabau sabau deleted the fabo/1791-fix-voyager-init branch January 4, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initing Voyager for a network fails
2 participants