Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/game of stakes #1799

Merged
merged 34 commits into from
Jan 11, 2019
Merged

Fabo/game of stakes #1799

merged 34 commits into from
Jan 11, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Jan 4, 2019

Prepare for game of stakes release

Needs #1794

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit 945803d586b83d65547cd16f4cd5994eac2957ea is v0.27.0 see CHANGELOG. We need to do the other updates from v0.28.1

@faboweb
Copy link
Collaborator Author

faboweb commented Jan 4, 2019

No, Voyager was on 0.28.0-rc2. Which breaking changes were there till now?

@fedekunze fedekunze changed the title Fabo/game of stakes WIP: Fabo/game of stakes Jan 7, 2019
@fedekunze fedekunze self-assigned this Jan 7, 2019
@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #1799 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1799      +/-   ##
===========================================
+ Coverage    95.05%   95.07%   +0.01%     
===========================================
  Files          122      122              
  Lines         2953     2982      +29     
  Branches       122      128       +6     
===========================================
+ Hits          2807     2835      +28     
  Misses         137      137              
- Partials         9       10       +1
Impacted Files Coverage Δ
app/src/main/index.js 76% <ø> (ø) ⬆️
app/src/renderer/connectors/lcdClient.js 98% <100%> (ø) ⬆️
.../renderer/components/common/TmConnectedNetwork.vue 89.47% <0%> (-0.53%) ⬇️
...src/renderer/components/common/PagePreferences.vue 100% <0%> (ø) ⬆️
app/src/renderer/vuex/modules/connection.js 100% <0%> (ø) ⬆️
...c/renderer/components/common/TmModalNodeHalted.vue 100% <0%> (ø) ⬆️
app/src/renderer/components/wallet/PageSend.vue 100% <0%> (ø) ⬆️
app/src/renderer/components/common/AppMenu.vue 100% <0%> (ø) ⬆️
app/src/renderer/vuex/getters.js 93.47% <0%> (+0.14%) ⬆️
...src/renderer/components/common/TmSessionSignIn.vue 90.9% <0%> (+0.58%) ⬆️

@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #1799 into develop will decrease coverage by 0.18%.
The diff coverage is 93.16%.

@@             Coverage Diff             @@
##           develop    #1799      +/-   ##
===========================================
- Coverage    94.85%   94.67%   -0.19%     
===========================================
  Files          123      123              
  Lines         2954     2946       -8     
  Branches       121      121              
===========================================
- Hits          2802     2789      -13     
- Misses         143      148       +5     
  Partials         9        9
Impacted Files Coverage Δ
app/src/renderer/vuex/modules/send.js 100% <ø> (ø) ⬆️
...rc/renderer/components/wallet/PageTransactions.vue 93.75% <ø> (ø) ⬆️
app/src/main/index.js 76.15% <ø> (ø) ⬆️
.../renderer/components/governance/PageGovernance.vue 100% <ø> (ø) ⬆️
.../src/renderer/components/staking/PageValidator.vue 98.59% <100%> (-0.16%) ⬇️
.../src/renderer/components/governance/LiProposal.vue 100% <100%> (ø) ⬆️
app/src/renderer/connectors/lcdClient.js 98.07% <100%> (+0.07%) ⬆️
app/src/renderer/vuex/modules/wallet.js 100% <100%> (ø) ⬆️
app/src/renderer/vuex/modules/delegation.js 100% <100%> (ø) ⬆️
app/src/renderer/connectors/lcdClientMock.js 96.19% <91.83%> (-1.42%) ⬇️

@fedekunze
Copy link
Contributor

fedekunze commented Jan 7, 2019

@faboweb redelegation throws an out of gas in location: WriteFlat error

@faboweb faboweb changed the title WIP: Fabo/game of stakes Fabo/game of stakes Jan 8, 2019
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor fix and then we should be good to go

app/src/renderer/components/governance/PageProposal.vue Outdated Show resolved Hide resolved
app/src/renderer/components/governance/PageProposal.vue Outdated Show resolved Hide resolved
app/src/renderer/components/governance/PageProposal.vue Outdated Show resolved Hide resolved
fedekunze and others added 3 commits January 9, 2019 17:41
Co-Authored-By: faboweb <frznhope@gmail.com>
Co-Authored-By: faboweb <frznhope@gmail.com>
Co-Authored-By: faboweb <frznhope@gmail.com>
@fedekunze
Copy link
Contributor

unit test is failing bc of prettier

@fedekunze
Copy link
Contributor

@faboweb and can we update the README and remove the no active testnets message ?

@faboweb
Copy link
Collaborator Author

faboweb commented Jan 10, 2019

@fedekunze delegation doesn't work

@fedekunze
Copy link
Contributor

why does it work with bondDenom but not with depositDenom ?

@fedekunze
Copy link
Contributor

fedekunze commented Jan 10, 2019

the submit proposal tx is not displayed on the PageTransactions and the link to the proposalUrl on the deposit tx is wrong: it says governance/proposals/1 and it should say governance/1

@fedekunze
Copy link
Contributor

also unbonding is not working

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK. The only minor bug I found was the header on PageProposal. But nbd we can fix it afterwards:

screen shot 2019-01-10 at 10 42 15 pm

@faboweb faboweb merged commit 5685cdb into develop Jan 11, 2019
@faboweb faboweb deleted the fabo/game-of-stakes branch January 11, 2019 10:31
@faboweb
Copy link
Collaborator Author

faboweb commented Jan 11, 2019

Merged because coverage was only missing on lcdClientMock which we deprecate.

@faboweb
Copy link
Collaborator Author

faboweb commented Jan 11, 2019

@fedekunze bug was files #1803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants