Fix 0.6.0 bugs. #723
Closed
Fix 0.6.0 bugs. #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #723 +/- ##
========================================
Coverage 86.84% 86.84%
========================================
Files 94 94
Lines 1566 1566
Branches 70 70
========================================
Hits 1360 1360
Misses 193 193
Partials 13 13
|
NodeGuy
force-pushed
the
david/720-fix-0.6.0-bugs
branch
from
2dd77d2 to
ebc2b7d
Compare
NodeGuy
commented
May 21, 2018
| // the mocked node is automatically connected | ||
| dispatch("reconnected") | ||
| } | ||
| dispatch("reconnected") |
There was a problem hiding this comment.
@faboweb Please review this change; it fixed the bug but it's unclear to me why we originally wanted to stop the LCD.
There was a problem hiding this comment.
Do you let your car running while you use your bike? ;)
Closed
faboweb
reviewed
May 22, 2018
| list-item(to="/staking" exact @click.native="close" title="Staking" v-bind:class="{ 'active': isValidatorPage }" v-if="config.devMode") | ||
|
|
||
| // Hide staking for now (see https://github.com/cosmos/voyager/issues/720). | ||
| //- list-item(to="/staking" exact @click.native="close" title="Staking" v-bind:class="{ 'active': isValidatorPage }" v-if="config.devMode") |
There was a problem hiding this comment.
we have a development mode flag v-if="config.devMode" that is already applied. If the staking option is still visible, the user has NODE_ENV=development set globally.
faboweb
requested changes
May 22, 2018
|
I fixed the reconnection bug in #726 while shutting down the lcd process. If this is acceptable let's use that fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
closes: #720
Screenshots
❤️ Thank you!