fix lcd reconnection after mocked connection #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## develop #726 +/- ##
========================================
Coverage 86.84% 86.84%
========================================
Files 94 94
Lines 1566 1566
Branches 70 70
========================================
Hits 1360 1360
Misses 193 193
Partials 13 13
|
NodeGuy
approved these changes
May 22, 2018
faboweb
pushed a commit
that referenced
this pull request
Jun 2, 2020
* resolve dependencies alerts * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
part of #720
The problem was, that the main process wanted to stop the lcd process after is was already stopped. The error was not properly surfaced.
❤️ Thank you!