remove the indirect dependency on arrayvec #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by turning off default-features
|
Is a release of |
No, this crate has been feature-complete for a while so I don't plan work for it. I'm amenable to releasing new versions if changes get merged. |
|
Is the removal of the dependency on arrayvec considered a worthwhile change? |
|
Thanks for the change! Sorry for not merging this sooner, I lost track of it. There are a few other small PRs and issues outstanding right now. When those get resolved I will probably push a new release. |
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Jun 27, 2024
bump strip-ansi-escapes This bumps `strip-ansi-escapes` to remove arrayvec from it's deps (luser/strip-ansi-escapes#8) Should Cargo.lock be commited too to track it's working state?
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Jun 27, 2024
bump strip-ansi-escapes This bumps `strip-ansi-escapes` to remove arrayvec from it's deps (luser/strip-ansi-escapes#8) Should Cargo.lock be commited too to track it's working state? changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran
cargo testafter turning offdefault-featuresand everything continued to work as expected.This will result in projects depending on this crate no longer pulling in an old
arrayvec.