Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump strip-ansi-escapes #12992

Merged
merged 1 commit into from
Jun 27, 2024
Merged

bump strip-ansi-escapes #12992

merged 1 commit into from
Jun 27, 2024

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Jun 24, 2024

This bumps strip-ansi-escapes to remove arrayvec from it's deps (luser/strip-ansi-escapes#8)

Should Cargo.lock be commited too to track it's working state?

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jun 24, 2024

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 24, 2024
@Alexendoo
Copy link
Member

Thanks!

We have Cargo.locks ignored since we're part of the rust-lang/rust workspace, though I guess that doesn't apply to lintcheck itself. But leaving it as is seems fine

@bors r+

@bors
Copy link
Contributor

bors commented Jun 27, 2024

📌 Commit 606ada1 has been approved by Alexendoo

It is now in the queue for this repository.

bors added a commit that referenced this pull request Jun 27, 2024
bump strip-ansi-escapes

This bumps `strip-ansi-escapes` to remove arrayvec from it's deps (luser/strip-ansi-escapes#8)

Should Cargo.lock be commited too to track it's working state?
@bors
Copy link
Contributor

bors commented Jun 27, 2024

⌛ Testing commit 606ada1 with merge e68311b...

@bors
Copy link
Contributor

bors commented Jun 27, 2024

💔 Test failed - checks-action_test

@klensy
Copy link
Contributor Author

klensy commented Jun 27, 2024

Oops, fixed.

@Alexendoo
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Jun 27, 2024

⌛ Testing commit 606ada1 with merge 4ddc8a2...

@bors
Copy link
Contributor

bors commented Jun 27, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 4ddc8a2 to master...

@bors bors merged commit 4ddc8a2 into rust-lang:master Jun 27, 2024
8 checks passed
@blyxyas
Copy link
Member

blyxyas commented Jun 27, 2024

Oh I thought I approved this. Maybe I forgot to actually push the "Approve" button 😅. Anyways, LGTM, thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants