Skip to content

Commit

Permalink
Patch 1 (#478)
Browse files Browse the repository at this point in the history
* Update create_model.php

Corrected `implode()` in `ngRestScopes()` in create model command template.
implode ( string $glue , array $pieces )

* Update CHANGELOG.md

Adjusted for pr

* Update .travis.yml

Co-authored-by: Basil <git@nadar.io>
  • Loading branch information
JohnnyMcWeed and nadar authored Apr 9, 2020
1 parent 6deb25c commit 6c4fa6d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ services:

install:
- travis_retry composer self-update && composer --version
- composer config -g github-oauth.github.com "$TOKEN"
- composer config -g github-oauth.github.com $TOKEN
- export PATH="$HOME/.composer/vendor/bin:$PATH"
- travis_retry composer install --verbose --prefer-dist --optimize-autoloader --no-progress --no-interaction

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ In order to read more about upgrading and BC breaks have a look at the [UPGRADE

## 3.2.0

+ [#478](https://github.com/luyadev/luya-module-admin/pull/478) Corrected `implode()` in `ngRestScopes()` in create model command template.
+ [#475](https://github.com/luyadev/luya-module-admin/pull/475) Added new option to return a none empty tag title.
+ [#476](https://github.com/luyadev/luya-module-admin/pull/476) Ensure importers skip objects which are not of the certain type. This is importend when a folder is used for other data.

Expand Down
6 changes: 3 additions & 3 deletions src/commands/views/crud/create_model.php
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ public function ngRestAttributeTypes()
public function ngRestScopes()
{
return [
['list', ['<?= implode($fields, "', '"); ?>']],
[['create', 'update'], ['<?= implode($fields, "', '"); ?>']],
['list', ['<?= implode("', '", $fields); ?>']],
[['create', 'update'], ['<?= implode("', '", $fields); ?>']],
['delete', false],
];
}
}

This comment has been minimized.

}

0 comments on commit 6c4fa6d

Please sign in to comment.