Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #478

Merged
merged 3 commits into from
Apr 9, 2020
Merged

Patch 1 #478

merged 3 commits into from
Apr 9, 2020

Conversation

JohnnyMcWeed
Copy link
Contributor

What is the reason for changing

Correction.
https://www.php.net/manual/de/function.implode.php

JohnnyMcWeed and others added 3 commits April 9, 2020 02:07
Corrected `implode()` in `ngRestScopes()` in create model command template.
implode ( string $glue , array $pieces )
Adjusted for pr
Copy link
Member

@nadar nadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was not aware of that.

https://3v4l.org/bFYRJ

@nadar
Copy link
Member

nadar commented Apr 9, 2020

Currently we do have problems with travis auth tokens, even though the Token is provided in Travis Settings. The problem seems to appear only on PRs, not master. Therefore i will merge and check the master build afterwards.

@nadar nadar merged commit 6c4fa6d into luyadev:master Apr 9, 2020
slowfox089 pushed a commit to slowfox089/luya-module-admin that referenced this pull request Dec 10, 2020
* Update create_model.php

Corrected `implode()` in `ngRestScopes()` in create model command template.
implode ( string $glue , array $pieces )

* Update CHANGELOG.md

Adjusted for pr

* Update .travis.yml

Co-authored-by: Basil <git@nadar.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants