CMS Theme import and management

[boehsermoe]

luyadev/luya/issues/1916

ForThemeImporter see luyadev/luya-composer/pull/12

[nadar]

So this will require version 3.0 release

[nadar]

I would say we are almost there.

It would be nice to have an option to render the toolbar file, then we can at least ensure there are no syntax errors. Would be great! Thanks.

Thanks for the work, looking forward to merge.

[boehsermoe]

It would be nice to have an option to render the toolbar file, then we can at least ensure there are no syntax errors. Would be great! Thanks.

What do you mean with this? Where could syntax errors occur?

[nadar]

in the view file, so it thought it would be nice to just render the view file in the controller. (cause there are changes to the toolbar).

$ctrl = new DefaultController();
$this->assertNotNUll($ctrl->actionIndex());

something like this.

[boehsermoe]

@nadar I made a simple test for the toolbar rendering

[nadar]

Im terms of coverage, this looks good! Today i will make a review regarding phpdoc and coding standards, everything else looks good for me now 👍

[nadar]

please fix those phpdocs, afterwards we can merge. nice!

Maybe we should also adjust the guide and provide a screenshot about the new theme manager? (but of course in antoher PR in luyadev/luya)

https://luya.io/guide/app-themes

[codeclimate]

Code Climate has analyzed commit 973ff13 and detected 85 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	20
Duplication	65

The test coverage on the diff in this pull request is 83.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 39.1% (2.1% change).

View more on Code Climate.