Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guide + Demo: Manage themes in cms settings #1983

Closed
boehsermoe opened this issue Dec 18, 2019 · 3 comments
Closed

Guide + Demo: Manage themes in cms settings #1983

boehsermoe opened this issue Dec 18, 2019 · 3 comments

Comments

@boehsermoe
Copy link
Member

boehsermoe commented Dec 18, 2019 •
edited
Loading

Append the theme section of the guide (https://luya.io/guide/app-themes) with screenshot and some description for the theme management in cms settings

Also the luya demo https://demo.luya.io/ should be contains some example themes.

Based on luyadev/luya-module-cms/pull/211
@boehsermoe boehsermoe changed the title Guide: Manage themes in cms settings Guide + Demo: Manage themes in cms settings Dec 18, 2019
@boehsermoe
Copy link
Member Author

@nadar after new version deployment on demo.luya.io there should be setup two themes.

boehsermoe added a commit to boehsermoe/luya that referenced this issue Dec 18, 2019
@boehsermoe
theme management image for guide luyadev#1983
66220c3
@boehsermoe boehsermoe mentioned this issue Dec 18, 2019
Merged
nadar added a commit that referenced this issue Dec 27, 2019
@boehsermoe @nadar
Theme management for guide (#1984)
bf59559 
* Translation helper controler

* PHPdoc

* Correct parameter order for help

* Documentation for block preview luyadev/luya-module-cms#83

* Revert PHP doc

* Travis mysql connection failed

* config with env scope

* used call_user_func for callback

* Update Config.php

* theme load without exception as default

* theme load without exception as default

* theme load without exception as default

* Update ThemeManager.php

* changelog #1969

* Update CHANGELOG.md

* add php doc

* theme management image for guide #1983

* Update app-themes.md

Co-authored-by: Basil <git@nadar.io>
@nadar
Copy link
Member

nadar commented Dec 27, 2019 •
edited
Loading

It would be nice to have:

  1. The skeleton repo for themes: https://github.com/luyadev/luya-theme-skeleton
  2. Provide luyadev/luya-themes repo which contains out of the box themes, maybe you like to move your repo into the luyadev org?
  3. Include the new luya theme for demo.luya.io

@nadar
Copy link
Member

nadar commented Mar 11, 2020

The skeleton app is more or less ready, also the luya-themes repo. Thinking about using a theme on demo.luya.io sounds good to me but maybe in a later step.

@nadar nadar closed this as completed Mar 11, 2020
nadar added a commit that referenced this issue Apr 6, 2020
@boehsermoe @nadar
Theme basepath (#2002)
00eb345 
* Translation helper controler

* PHPdoc

* Correct parameter order for help

* Documentation for block preview luyadev/luya-module-cms#83

* Revert PHP doc

* Travis mysql connection failed

* config with env scope

* used call_user_func for callback

* Update Config.php

* theme load without exception as default

* theme load without exception as default

* theme load without exception as default

* Update ThemeManager.php

* changelog #1969

* Update CHANGELOG.md

* add php doc

* theme management image for guide #1983

* Update app-themes.md

* close #1970

* Update CHANGELOG.md

* Relative theme path to alias path

* Changelog

* Relative vendor path to alias path

* Tests for Relative vendor path to alias path

Co-authored-by: Basil <git@nadar.io>
nadar added a commit that referenced this issue Apr 13, 2020
@boehsermoe @nadar
Create theme command (#2012)
4e30778 
* Translation helper controler

* PHPdoc

* Correct parameter order for help

* Documentation for block preview luyadev/luya-module-cms#83

* Revert PHP doc

* Travis mysql connection failed

* config with env scope

* used call_user_func for callback

* Update Config.php

* theme load without exception as default

* theme load without exception as default

* theme load without exception as default

* Update ThemeManager.php

* changelog #1969

* Update CHANGELOG.md

* add php doc

* theme management image for guide #1983

* Update app-themes.md

* Theme command

* Create theme command

* Changelog

Co-authored-by: Basil <git@nadar.io>
nadar added a commit that referenced this issue Jul 2, 2020
@boehsermoe @nadar
Fix theme/create command (#2035)
bed31e2 
* Translation helper controler

* PHPdoc

* Correct parameter order for help

* Documentation for block preview luyadev/luya-module-cms#83

* Revert PHP doc

* Travis mysql connection failed

* config with env scope

* used call_user_func for callback

* Update Config.php

* theme load without exception as default

* theme load without exception as default

* theme load without exception as default

* Update ThemeManager.php

* changelog #1969

* Update CHANGELOG.md

* add php doc

* theme management image for guide #1983

* Update app-themes.md

* Theme command

* Create theme command

* Changelog

* fixed theme/create command #2020

* Changelog #2020

* Fix unit test for theme create command

* Fix unit test for theme create command

Co-authored-by: Basil <git@nadar.io>
boehsermoe added a commit to boehsermoe/luya that referenced this issue Jul 6, 2020
@boehsermoe
theme management image for guide luyadev#1983
5fde6b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boehsermoe @nadar