-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep basepath while theme loading #1970
Labels
Comments
I am not sure this is related, but cmslayouts doe not work with absolute paths:
as by yii defintion the absolute path must start with double slashes:
https://www.yiiframework.com/doc/api/2.0/yii-base-view#render()-detail Not sure we have to improve this in luya cms cmslayouts importer or theme manager, will do some research. |
boehsermoe
added a commit
to boehsermoe/luya
that referenced
this issue
Mar 15, 2020
Merged
nadar
added a commit
that referenced
this issue
Apr 6, 2020
* Translation helper controler * PHPdoc * Correct parameter order for help * Documentation for block preview luyadev/luya-module-cms#83 * Revert PHP doc * Travis mysql connection failed * config with env scope * used call_user_func for callback * Update Config.php * theme load without exception as default * theme load without exception as default * theme load without exception as default * Update ThemeManager.php * changelog #1969 * Update CHANGELOG.md * add php doc * theme management image for guide #1983 * Update app-themes.md * close #1970 * Update CHANGELOG.md * Relative theme path to alias path * Changelog * Relative vendor path to alias path * Tests for Relative vendor path to alias path Co-authored-by: Basil <git@nadar.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
loadThemeConfig
the basepath should be keep as relative path and which should also saved into database.luya/core/theme/ThemeManager.php
Line 57 in 8495329
The text was updated successfully, but these errors were encountered: