Theme bootstrap and layout fix #1963
Conversation
|
This is the base class for all modules, as far as i can see this won't work as this would run the code in every module also would the modules call the parent method in order to work. So we should move this section to the bootstrap class. |
|
You are right, I have overlooked that |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
core/theme/ThemeManager.php
Outdated
| */ | ||
| public function getThemes() | ||
| public function getThemes(bool $throwException = true) |
There was a problem hiding this comment.
Function getThemes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
There was a problem hiding this comment.
please remove boolean property type hint.
core/theme/ThemeManager.php
Outdated
| */ | ||
| public function getThemes() | ||
| public function getThemes(bool $throwException = true) |
There was a problem hiding this comment.
please remove boolean property type hint.
| */ | ||
| public function getThemes() | ||
| public function getThemes($throwException = true) |
There was a problem hiding this comment.
Function getThemes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
|
Code Climate has analyzed commit a8fa203 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 64.8% (0.0% change). View more on Code Climate. |
Small fix to load theme layout file automaticly