Extract common code for opening a link #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bar. When this fix is applied, the default target for opened links (internal or external browser) is taken from the preferences. Fixes lwindolf#1056, lwindolf#1089, lwindolf#1098
Previously, the following functions used almost the same code: - on_Itemlist_row_activated - on_popup_launch_item_selected - on_popup_launch_item_in_tab_selected - on_popup_launch_item_external_selected This common code was extracted to a new function.
lwindolf
added a commit
that referenced
this pull request
Dec 19, 2013
Extract common code for opening a link
lwindolf
added a commit
that referenced
this pull request
Dec 19, 2013
lwindolf
added a commit
that referenced
this pull request
Jan 13, 2014
… when opening links (patch by Daniel Seither)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the following functions used almost the same code:
This common code was extracted to a new function.