feat: integrate analytics #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
=========================================
Coverage ? 63.08%
=========================================
Files ? 370
Lines ? 8115
Branches ? 1435
=========================================
Hits ? 5119
Misses ? 2996
Partials ? 0 Continue to review full report at Codecov.
|
Pianist038801
force-pushed
the
feat/integrate-analytics
branch
3 times, most recently
from
a3f9940
to
a2f4ee4
Compare
5 tasks
jsonporter
reviewed
Nov 23, 2021
env.js
Outdated
| @@ -27,6 +27,10 @@ const STATUS_URL = process.env.STATUS_URL; | |||
| // This should only be used when Admin is also in unsecured mode. | |||
| const DISABLE_AUTH = process.env.DISABLE_AUTH; | |||
|
|
|||
| // Configure Google Analytics | |||
| const DISABLE_GA = process.env.DISABLE_GA; | |||
| const GA_TRACKING_ID = process.env.GA_TRACKING_ID; | |||
There was a problem hiding this comment.
We want this to default to G-0QW4DJWJ20. so process.env.GA_TRACKING_ID || 'G-0QW4DJWJ20
jsonporter
reviewed
Nov 23, 2021
src/client.tsx
Outdated
| @@ -11,6 +12,12 @@ const render = (Component: React.FC) => { | |||
| const initializeApp = () => { | |||
| const App = require('./components/App/App').App; | |||
|
|
|||
| const { DISABLE_GA, GA_TRACKING_ID } = env; | |||
|
|
|||
| if (!DISABLE_GA) { | |||
There was a problem hiding this comment.
This doesn't seem to work as intended. ENV values of "false" or false both don't seem to fire this.
Pianist038801
force-pushed
the
feat/integrate-analytics
branch
from
a2f4ee4
to
51dd533
Compare
Signed-off-by: Pianist038801 <steven@union.ai>
Pianist038801
force-pushed
the
feat/integrate-analytics
branch
from
51dd533
to
42fc6c6
Compare
added 2 commits
December 14, 2021 12:11
Signed-off-by: Pianist038801 <steven@union.ai>
jsonporter
reviewed
Dec 14, 2021
README.rst
Outdated
|
|
||
| This application makes use of the `react-ga4 <https://github.com/PriceRunner/react-ga4>`_ | ||
| libary to include Google Analytics tracking code in a website or app. For all the environments, it is configured using ENABLE_GA environment variable. | ||
| By default, it's enabled like this: ``ENABLED=true``. If you want to disable it, just remove the value. (ex. ``ENABLE_GA='``). |
There was a problem hiding this comment.
This says ENABLED=true but it should be ENABLE_GA =true, right?
Signed-off-by: Pianist038801 <steven@union.ai>
jsonporter
reviewed
Dec 14, 2021
src/client.tsx
Outdated
| @@ -11,6 +12,12 @@ const render = (Component: React.FC) => { | |||
| const initializeApp = () => { | |||
| const App = require('./components/App/App').App; | |||
|
|
|||
| const { ENABLE_GA, GA_TRACKING_ID } = env; | |||
|
|
|||
| if (ENABLE_GA) { | |||
There was a problem hiding this comment.
All env vars come back as strings so this will always be true if the var exists. That means you'll need to do an explicit check here for either !="false" || !="0".
Signed-off-by: Pianist038801 <steven@union.ai>
flyte-bot
added a commit
that referenced
this pull request
Dec 15, 2021
# [0.35.0](http://github.com/lyft/flyteconsole/compare/v0.34.0...v0.35.0) (2021-12-15) ### Features * integrate analytics ([#244](http://github.com/lyft/flyteconsole/issues/244)) ([2726b07](http://github.com/lyft/flyteconsole/commit/2726b07a012a8a12b35752fbe714e1a148f630f7))
|
🎉 This PR is included in version 0.35.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
govalt
pushed a commit
that referenced
this pull request
Jan 15, 2022
* feat: integrate analytics Signed-off-by: Pianist038801 <steven@union.ai> * fix: remove DISABLE_AUTH Signed-off-by: Pianist038801 <steven@union.ai> * fix: typo in the README Signed-off-by: Pianist038801 <steven@union.ai> * fix: analytics configuration Signed-off-by: Pianist038801 <steven@union.ai> Co-authored-by: Pianist038801 <steven@union.ai> Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
govalt
pushed a commit
that referenced
this pull request
Jan 15, 2022
# [0.35.0](http://github.com/lyft/flyteconsole/compare/v0.34.0...v0.35.0) (2021-12-15) ### Features * integrate analytics ([#244](http://github.com/lyft/flyteconsole/issues/244)) ([2726b07](http://github.com/lyft/flyteconsole/commit/2726b07a012a8a12b35752fbe714e1a148f630f7)) Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pianist038801 steven@union.ai
This integrates Google Analytics into the console application.
Are all requirements met?
Tracking Issue
fixes flyteorg/flyte#1442
Follow-up issue
NA