fix: show full millisecond values for subsecond durations #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
podehnal
approved these changes
Jul 6, 2020
BobNisco
approved these changes
Jul 6, 2020
Codecov Report
@@ Coverage Diff @@
## next #81 +/- ##
=======================================
Coverage ? 63.16%
=======================================
Files ? 363
Lines ? 5699
Branches ? 845
=======================================
Hits ? 3600
Misses ? 2099
Partials ? 0 Continue to review full report at Codecov.
|
schottra
added a commit
that referenced
this pull request
Jul 20, 2020
* fix: show full millisecond values for subsecond durations (#81) * Bump npm from 6.14.5 to 6.14.6 (#82) Bumps [npm](https://github.com/npm/cli) from 6.14.5 to 6.14.6. - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md) - [Commits](npm/cli@v6.14.5...v6.14.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: show info message for un-launchable workflows (#84) * refactor: adding utility to help determine if an input type is supported * fix: adding detection and special rendering for unlaunchable workflows * fix: implementing error message for unlaunchable workflows * chore: docs * chore: pr feedback * feat: Enables support for Blobs on the Launch form (#86) * refactor: adds scaffolding for blob input support * fix: add controls and processing for blob fields * fix: support using string values for dimensionality in collections * fix: more info so validators can check subfields * test: tests for blob input helper * test: remaining tests for blobs * chore: cleanup * refactor: adding some type guards * test: fixing some test cases Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Jul 20, 2020
# [0.8.0](http://github.com/lyft/flyteconsole/compare/v0.7.3...v0.8.0) (2020-07-20) ### Features * 0.8.0 release ([#87](http://github.com/lyft/flyteconsole/issues/87)) ([65f2a81](http://github.com/lyft/flyteconsole/commit/65f2a8102a5cdbf2456868502dc3e7628cfc1433)), closes [#81](http://github.com/lyft/flyteconsole/issues/81) [#82](http://github.com/lyft/flyteconsole/issues/82) [#84](http://github.com/lyft/flyteconsole/issues/84) [#86](http://github.com/lyft/flyteconsole/issues/86)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#97
For values that are less than 1 second, we can/should show
(value)msinstead of just showing<1s. The exact millisecond value is preferable when rendering inputs/outputs.