Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show info message for un-launchable workflows #84

Merged
merged 5 commits into from
Jul 15, 2020

Conversation

schottra
Copy link
Contributor

flyteorg/flyte#291

This change improves the experience when a user is attempting to launch a Workflow for which it is impossible to specify a required value.
This can happen if the Workflow defines a required input with a type that the Console doesn't support yet (such as Schema, Binary, etc). If the Launch Plan specifies a default value, or we are re-launching an execution from which we can copy the value, it is still possible to proceed. Otherwise, we won't be able to successfully launch.
The previous experience was a little confusing, because we would only show a generic error at the bottom of the form after attempting to submit. The new experience is to show the user an error message indicating which inputs are unsupported, and directing them to either select a Launch Plan which provides a value, or to use the CLI to launch the workflow

image

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2020

Codecov Report

Merging #84 into next will increase coverage by 0.52%.
The diff coverage is 87.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next      #84      +/-   ##
==========================================
+ Coverage   62.95%   63.47%   +0.52%     
==========================================
  Files         363      364       +1     
  Lines        5699     5772      +73     
  Branches      845      873      +28     
==========================================
+ Hits         3588     3664      +76     
+ Misses       2111     2108       -3     
Impacted Files Coverage Δ
src/components/Launch/LaunchWorkflowForm/styles.ts 100.00% <ø> (ø)
src/components/Launch/LaunchWorkflowForm/types.ts 100.00% <ø> (ø)
src/common/utils.ts 91.66% <20.00%> (-8.34%) ⬇️
...ts/Launch/LaunchWorkflowForm/inputHelpers/utils.ts 85.00% <82.75%> (-6.67%) ⬇️
...nchWorkflowForm/UnsupportedRequiredInputsError.tsx 94.11% <94.11%> (ø)
...s/Launch/LaunchWorkflowForm/LaunchWorkflowForm.tsx 100.00% <100.00%> (ø)
.../components/Launch/LaunchWorkflowForm/constants.ts 100.00% <100.00%> (ø)
.../components/Launch/LaunchWorkflowForm/getInputs.ts 96.15% <100.00%> (+0.32%) ⬆️
.../LaunchWorkflowForm/inputHelpers/test/testCases.ts 100.00% <100.00%> (ø)
...onents/Launch/LaunchWorkflowForm/test/constants.ts 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f7b3c6...b4fe2eb. Read the comment docs.

Copy link
Contributor

@BobNisco BobNisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@schottra schottra merged commit 8367375 into next Jul 15, 2020
schottra added a commit that referenced this pull request Jul 20, 2020
* fix: show full millisecond values for subsecond durations (#81)

* Bump npm from 6.14.5 to 6.14.6 (#82)

Bumps [npm](https://github.com/npm/cli) from 6.14.5 to 6.14.6.
- [Release notes](https://github.com/npm/cli/releases)
- [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md)
- [Commits](npm/cli@v6.14.5...v6.14.6)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: show info message for un-launchable workflows (#84)

* refactor: adding utility to help determine if an input type is supported

* fix: adding detection and special rendering for unlaunchable workflows

* fix: implementing error message for unlaunchable workflows

* chore: docs

* chore: pr feedback

* feat: Enables support for Blobs on the Launch form (#86)

* refactor: adds scaffolding for blob input support

* fix: add controls and processing for blob fields

* fix: support using string values for dimensionality in collections

* fix: more info so validators can check subfields

* test: tests for blob input helper

* test: remaining tests for blobs

* chore: cleanup

* refactor: adding some type guards

* test: fixing some test cases

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@schottra schottra deleted the handle-unsupported-required-inputs branch September 9, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants