-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show info message for un-launchable workflows #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #84 +/- ##
==========================================
+ Coverage 62.95% 63.47% +0.52%
==========================================
Files 363 364 +1
Lines 5699 5772 +73
Branches 845 873 +28
==========================================
+ Hits 3588 3664 +76
+ Misses 2111 2108 -3
Continue to review full report at Codecov.
|
BobNisco
reviewed
Jul 15, 2020
src/components/Launch/LaunchWorkflowForm/useLaunchWorkflowFormState.ts
Outdated
Show resolved
Hide resolved
BobNisco
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
13 tasks
schottra
added a commit
that referenced
this pull request
Jul 20, 2020
* fix: show full millisecond values for subsecond durations (#81) * Bump npm from 6.14.5 to 6.14.6 (#82) Bumps [npm](https://github.com/npm/cli) from 6.14.5 to 6.14.6. - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md) - [Commits](npm/cli@v6.14.5...v6.14.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: show info message for un-launchable workflows (#84) * refactor: adding utility to help determine if an input type is supported * fix: adding detection and special rendering for unlaunchable workflows * fix: implementing error message for unlaunchable workflows * chore: docs * chore: pr feedback * feat: Enables support for Blobs on the Launch form (#86) * refactor: adds scaffolding for blob input support * fix: add controls and processing for blob fields * fix: support using string values for dimensionality in collections * fix: more info so validators can check subfields * test: tests for blob input helper * test: remaining tests for blobs * chore: cleanup * refactor: adding some type guards * test: fixing some test cases Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Jul 20, 2020
# [0.8.0](http://github.com/lyft/flyteconsole/compare/v0.7.3...v0.8.0) (2020-07-20) ### Features * 0.8.0 release ([#87](http://github.com/lyft/flyteconsole/issues/87)) ([65f2a81](http://github.com/lyft/flyteconsole/commit/65f2a8102a5cdbf2456868502dc3e7628cfc1433)), closes [#81](http://github.com/lyft/flyteconsole/issues/81) [#82](http://github.com/lyft/flyteconsole/issues/82) [#84](http://github.com/lyft/flyteconsole/issues/84) [#86](http://github.com/lyft/flyteconsole/issues/86)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#291
This change improves the experience when a user is attempting to launch a Workflow for which it is impossible to specify a required value.
This can happen if the Workflow defines a required input with a type that the Console doesn't support yet (such as Schema, Binary, etc). If the Launch Plan specifies a default value, or we are re-launching an execution from which we can copy the value, it is still possible to proceed. Otherwise, we won't be able to successfully launch.
The previous experience was a little confusing, because we would only show a generic error at the bottom of the form after attempting to submit. The new experience is to show the user an error message indicating which inputs are unsupported, and directing them to either select a Launch Plan which provides a value, or to use the CLI to launch the workflow