Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge apache 963dce6 #48

Merged
merged 8 commits into from
Jul 1, 2019
Merged

Merge apache 963dce6 #48

merged 8 commits into from
Jul 1, 2019

Conversation

khtruong
Copy link

@khtruong khtruong commented Jul 1, 2019

Merge apache 963dce6 into lyft-master

@khtruong khtruong requested a review from betodealmeida July 1, 2019 21:17
@betodealmeida
Copy link

+1

@codecov-io
Copy link

codecov-io commented Jul 1, 2019

Codecov Report

Merging #48 into lyft-master will increase coverage by 0.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           lyft-master      #48      +/-   ##
===============================================
+ Coverage        64.89%   64.93%   +0.04%     
===============================================
  Files              468      468              
  Lines            22493    22514      +21     
  Branches          2472     2474       +2     
===============================================
+ Hits             14596    14620      +24     
+ Misses            7762     7759       -3     
  Partials           135      135
Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 78.28% <ø> (ø) ⬆️
superset/sql_lab.py 77% <100%> (+0.12%) ⬆️
superset/assets/src/addSlice/AddSliceContainer.jsx 72.72% <100%> (ø) ⬆️
superset/assets/src/components/TableSelector.jsx 84.16% <100%> (-0.52%) ⬇️
superset/views/core.py 73.08% <73.33%> (-0.01%) ⬇️
...src/components/FilterableTable/FilterableTable.jsx 83.22% <82.6%> (-0.34%) ⬇️
superset/views/utils.py 88.04% <83.33%> (+0.26%) ⬆️
superset/utils/core.py 88.1% <0%> (+0.17%) ⬆️
superset/views/base.py 71.5% <0%> (+1%) ⬆️
superset/db_engine_specs/sqlite.py 66.66% <0%> (+20.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b0d482...92f098f. Read the comment docs.

@khtruong khtruong merged commit dec808b into lyft-master Jul 1, 2019
@DiggidyDave DiggidyDave deleted the merge_apache_963dce6 branch August 19, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants