Set encoding when saving csv #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mski-iksm
requested review from
hirosassa,
Hi-king,
ukky17,
kitagry and
ujiuji1259
|
@mski-iksm Could you consider adding some light load/save test cases? |
kitagry
approved these changes
Jun 7, 2023
|
LGTM |
ukky17
approved these changes
Jun 7, 2023
Co-authored-by: Jumpei Ukita <ukky17@users.noreply.github.com>
|
@mski-iksm just a friendly reminder. What's this PR status? |
@hirosassa I'm still working on adding tests. Please wait for few more days. |
|
@Hi-king I've added small tests. Please re-review. Thank you. |
|
@mski-iksm THX!LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added CsvFileProcessor._encoding to allow specifying encodings when dumping in csv.