Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fix csv encoding option #327

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

ujiuji1259
Copy link
Collaborator

#317 added the encoding option into CsvFileProcessor, but the following code in the docs doesn't work.

def output(self):
    return self.make_target('file_name.csv', encoding='cp932')

In fact, we have to directly pass CsvFileProcessor with encoding='cp932' to TaskOnKart.make_target.

@Hi-king
Copy link
Member

Hi-king commented Oct 11, 2023

@ujiuji1259 THX!

@Hi-king Hi-king merged commit a933055 into m3dev:master Oct 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants