Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix is_parameter_call #392

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix is_parameter_call #392

merged 1 commit into from
Sep 3, 2024

Conversation

kitagry
Copy link
Member

@kitagry kitagry commented Aug 31, 2024

Currently, luigi doesn't provide py.typed. it will be released next to 3.5.1.

spotify/luigi#3297

With the following code, we can't assume type correctly.

from luigi import Parameter

class MyTask(gokart.TaskOnKart):
    param = Parameter()

@kitagry kitagry marked this pull request as ready for review September 2, 2024 08:17
Copy link
Contributor

@hiro-o918 hiro-o918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mski-iksm mski-iksm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kitagry kitagry merged commit d4d51f8 into master Sep 3, 2024
5 checks passed
@kitagry kitagry deleted the fix-parameter-check branch September 3, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants