Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add py.typed for type checking #3297

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Conversation

hiro-o918
Copy link
Contributor

Description

Add py.typed marker
https://peps.python.org/pep-0561/#packaging-type-information

Motivation and Context

I want to run type checking on my project with lugi.

Have you tested this? If so, how?

@hiro-o918 hiro-o918 requested review from dlstadther and a team as code owners July 21, 2024 12:49
Copy link
Collaborator

@dlstadther dlstadther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if you'll run into issue while type checking. But I'll approve to include the ability.

@dlstadther dlstadther merged commit 06bdf64 into spotify:master Jul 21, 2024
49 of 51 checks passed
@hiro-o918
Copy link
Contributor Author

Thank you for your merging.
In detail, if there is no py.typed, all the classes are handled as Any and no type checking works.
This can makes us write invalid typing as type annotations, because it is not checked by type checkers like mypy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants