switch to new serialization mechanism

[remicollet]

See
https://wiki.php.net/rfc/phase_out_serializable
https://wiki.php.net/rfc/custom_object_serialization

So this is supported since 7.4, and mandatory in 8.1

Drop Serializable interface usage, and implement new magic methods

NOTICE: this mean incompatibility with previous version and serialized data.

BTW.... serialized data should only be used for local temporary data... should be...

Test suite passes with both 8.0.7 and 8.1.0alpha1

P.S. old implementation is kept where used for toString.

[codecov]

Codecov Report

Merging #114 (88ef341) into master (28a1848) will decrease coverage by 0.07%.
The diff coverage is 75.40%.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   85.73%   85.66%   -0.08%     
==========================================
  Files          42       42              
  Lines        9193     9210      +17     
==========================================
+ Hits         7882     7890       +8     
- Misses       1311     1320       +9     

Impacted Files	Coverage Δ
src/php_http_message_body.c	84.89% <61.53%> (-1.74%)	⬇️
src/php_http_message.c	87.28% <66.66%> (-0.05%)	⬇️
src/php_http_querystring.c	91.94% <83.33%> (+0.17%)	⬆️
src/php_http_header.c	83.54% <88.88%> (-0.21%)	⬇️
src/php_http_header_parser.c	94.62% <0.00%> (-0.03%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28a1848...88ef341. Read the comment docs.

[remicollet]

Notice: I kept old behavior to raise a warning for bad data during unserialization, but probably make sense to raise an exception, like in php-src (ex in Spl)

[m6w6]

Thanks!

Looks like this requires a new major version, due to dropping Serializable.

[m6w6]

Quote:

• In PHP 8.1, declaring an “only Serializable” class will throw a deprecation warning. Other implementations of Serializable will be accepted without a deprecation warning, because libraries supporting PHP < 7.4 will generally need to implement both the old and new mechanisms.
• In PHP 9.0 the Serializable interface will be removed and unserialize() will reject payloads using the C serialization format. Code needing to support both PHP < 7.4 and PHP >= 9.0 may polyfill the Serializable interface, though it will have no effect on serialization.

So it looks like it would be best to keep both, Serializable and the new magic methods until PHP-9.

[Jan-E]

So it looks like it would be best to keep both, Serializable and the new magic methods until PHP-9.

n00b question: does this imply that supporting ZEND_ACC_NOT_SERIALIZABLE is also recommended? See a comparable issue for the msgpack extension: msgpack/msgpack-php#161

[Jan-E]

FWIW: I am running into new deprecations with PHP 8.1.0 beta 1:

Deprecated: Return type of http\Client::attach(SplObserver $observer) should either be compatible with SplSubject::attach(SplObserver $observer): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
Deprecated: Return type of http\Client::detach(SplObserver $observer) should either be compatible with SplSubject::detach(SplObserver $observer): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
Deprecated: Return type of http\Client::notify(?http\Client\Request $request = , $progress = ) should either be compatible with SplSubject::notify(): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

[m6w6]

FWIW: I am running into new deprecations with PHP 8.1.0 beta 1:

Deprecated: Return type of http\Client::attach(SplObserver $observer) should either be compatible with SplSubject::attach(SplObserver $observer): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
Deprecated: Return type of http\Client::detach(SplObserver $observer) should either be compatible with SplSubject::detach(SplObserver $observer): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
Deprecated: Return type of http\Client::notify(?http\Client\Request $request = , $progress = ) should either be compatible with SplSubject::notify(): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

Yes, I'm not sure how to handle this yet; it probably needs a new major version fixing the method signatures.