Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix proto for 8.1.0beta2 #118

Closed
wants to merge 2 commits into from
Closed

fix proto for 8.1.0beta2 #118

wants to merge 2 commits into from

Conversation

remicollet
Copy link
Collaborator

Without


$ php -n -d extension=raphf -d extension=modules/http.so  -v

Deprecated: Return type of http\Client::attach(SplObserver $observer) should either be compatible with SplSubject::attach(SplObserver $observer): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0

Deprecated: Return type of http\Client::detach(SplObserver $observer) should either be compatible with SplSubject::detach(SplObserver $observer): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0

Deprecated: Return type of http\Client::notify(?http\Client\Request $request = <default>, $progress = <default>) should either be compatible with SplSubject::notify(): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0

With

=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped    :    0
Exts tested     :  123
---------------------------------------------------------------------

Number of tests :  202               199
Tests skipped   :    3 (  1.5%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    0 (  0.0%) (  0.0%)
Tests passed    :  199 ( 98.5%) (100.0%)
---------------------------------------------------------------------
Time taken      :   10 seconds
=====================================================================

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #118 (c3012ed) into master (114dee0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   85.41%   85.41%           
=======================================
  Files          42       42           
  Lines        9245     9245           
=======================================
  Hits         7897     7897           
  Misses       1348     1348           
Impacted Files Coverage Δ
src/php_http_client.c 87.08% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 114dee0...c3012ed. Read the comment docs.

@remicollet
Copy link
Collaborator Author

Sorry, the second commit should have been in a separate commit.... I create mess in my local git...

@m6w6
Copy link
Owner

m6w6 commented Aug 9, 2021

Hm... contrary to ignoring E_DEPRECATED, this changes seem to crash with master?

@m6w6 m6w6 closed this in b9e1564 Aug 10, 2021
@remicollet remicollet deleted the issue-php81b2 branch August 10, 2021 12:47
m6w6 added a commit that referenced this pull request Aug 30, 2021
* Fixed PHP-8.1 compatibility (see gh issues #114, #115 and #118)
* Fixed cookies failing with libcurl >= 7.77 (see gh issue #116)
* Fixed tests using $_ENV instead of getenv() to find executables in PATH (see gh issue #113)
* Added http\Env::reset(): resets internal HTTP request cache (see gh issue #90)
m6w6 added a commit that referenced this pull request Aug 30, 2021
* Fixed PHP-8.1 compatibility (see gh issues #114, #115 and #118)
* Fixed cookies failing with libcurl >= 7.77 (see gh issue #116)
* Fixed tests using $_ENV instead of getenv() to find executables in PATH (see gh issue #113)
* Added http\Env::reset(): resets internal HTTP request cache (see gh issue #90)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants