Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BYTEA unescaping support #38

Closed
wants to merge 5 commits into from
Closed

Add BYTEA unescaping support #38

wants to merge 5 commits into from

Conversation

danog
Copy link
Contributor

@danog danog commented Oct 25, 2020

No description provided.

m6w6
m6w6 requested changes Oct 27, 2020
View reviewed changes
Copy link
Owner

@m6w6 m6w6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case, too.

php_pq.h Outdated Show resolved Hide resolved
src/php_pqres.c Outdated Show resolved Hide resolved
src/php_pqres.h Outdated Show resolved Hide resolved
@m6w6
Copy link
Owner

m6w6 commented Nov 19, 2020

Please add a test case if you want this to be merged.

Thank you for your contribution!

@danog
Copy link
Contributor Author

danog commented Nov 27, 2020

Hi, sorry for the lack of activity.

Indeed I have tried writing a testcase for this, but I could not find a way to return a forcefully escaped result from postgres, except when using my own application))))

@m6w6
Copy link
Owner

m6w6 commented Aug 11, 2021

Fixup committed as a4fefa8

@m6w6 m6w6 closed this Aug 11, 2021
m6w6 added a commit that referenced this pull request Aug 30, 2021
@m6w6
release 2.2.0
16759d5 
* Fixed PHP-8.1 compatibility (see gh issues #40 and #41)
* Fixed asynchronous actions not cleared prior some synchronous actions
* Added connection constants of PostgreSQL-10+ to pq\Connection:
  CHECK_WRITABLE, CONSUME, and GSS_STARTUP
* Added BYTEA unescaping support (see gh issue #38)
m6w6 added a commit that referenced this pull request Aug 30, 2021
@m6w6
release 2.2.0
1eca2fe 
* Fixed PHP-8.1 compatibility (see gh issues #40 and #41)
* Fixed asynchronous actions not cleared prior some synchronous actions
* Added connection constants of PostgreSQL-10+ to pq\Connection:
  CHECK_WRITABLE, CONSUME, and GSS_STARTUP
* Added BYTEA unescaping support (see gh issue #38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m6w6 m6w6 m6w6 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danog @m6w6