Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prototype for 8.1 #40

Merged
merged 2 commits into from
Jun 11, 2021
Merged

fix prototype for 8.1 #40

merged 2 commits into from
Jun 11, 2021

Conversation

remicollet
Copy link
Collaborator

@remicollet remicollet commented Jun 11, 2021

Without:

TEST 51/51 [tests/unbuffered001.phpt]
========DIFF========
001+ Deprecated: Declaration of pq\DateTime::createFromFormat($format, $datetime, ?DateTimeZone $object = <default>) should be compatible with DateTime::createFromFormat(string $format, string $datetime, ?DateTimeZone $timezone = null): DateTime|false in Unknown on line 0
002+ 
003+ Deprecated: Declaration of pq\DateTime::jsonSerialize() should be compatible with JsonSerializable::jsonSerialize(): mixed in Unknown on line 0
     Test
     bool(false)
     bool(true)
--
========DONE========
FAIL unbuffered result [tests/unbuffered001.phpt] 

...

Tests failed    :   51 (100.0%) (100.0%)
Tests passed    :    0 (  0.0%) (  0.0%)

With PHP 8.1.0alpha1 and this patch

=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped    :    0
Exts tested     :   64
---------------------------------------------------------------------

Number of tests :   51                51
Tests skipped   :    0 (  0.0%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    0 (  0.0%) (  0.0%)
Tests passed    :   51 (100.0%) (100.0%)
---------------------------------------------------------------------
Time taken      :    1 seconds
=====================================================================

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #40 (aaf7e89) into master (7109996) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   76.61%   76.61%           
=======================================
  Files          17       17           
  Lines        3592     3592           
=======================================
  Hits         2752     2752           
  Misses        840      840           
Impacted Files Coverage Δ
src/php_pq_misc.c 72.63% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7109996...aaf7e89. Read the comment docs.

@m6w6 m6w6 merged commit 9e81713 into master Jun 11, 2021
@remicollet remicollet deleted the issue-php81 branch June 11, 2021 10:35
m6w6 added a commit that referenced this pull request Aug 30, 2021
* Fixed PHP-8.1 compatibility (see gh issues #40 and #41)
* Fixed asynchronous actions not cleared prior some synchronous actions
* Added connection constants of PostgreSQL-10+ to pq\Connection:
  CHECK_WRITABLE, CONSUME, and GSS_STARTUP
* Added BYTEA unescaping support (see gh issue #38)
m6w6 added a commit that referenced this pull request Aug 30, 2021
* Fixed PHP-8.1 compatibility (see gh issues #40 and #41)
* Fixed asynchronous actions not cleared prior some synchronous actions
* Added connection constants of PostgreSQL-10+ to pq\Connection:
  CHECK_WRITABLE, CONSUME, and GSS_STARTUP
* Added BYTEA unescaping support (see gh issue #38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants