Added check for attemptToFetchMajorUpgrade

[colorenz]

Hey,

the variable attemptToFetchMajorUpgrade has not been used yet.

I have added a check for attemptToFetchMajorUpgrade. I hope that was correct. My tests were successful. I hope its not to dirty :D

Best Regards

[erikng]

I don't think this logic is entirely correct. If the value is false, the device will hit the "else" block and then try to run the minor updates.

I think the check you're adding needs to be at the top of the "if statement" and to log if it's false and then return from the entire function so no other logic runs.

[colorenz]

Yes, that's what I thought at first.

Maybe I'm wrong, but I think my way would have the possibility to distribute a major and a minor update to different OS versions. Like described in the examples.
https://github.com/macadmins/nudge/wiki/targetedOSVersionsRule#real-world-example-2

• You can update BigSur 11.6.1 to 12.0.1 -> it goes to the major if block Utils().requireMajorUpgrade() && attemptToFetchMajorUpgrade
• You can update Monterey 12.0 to 12.0.1 -> it goes to the minor "else" block

Best Regards

[erikng]

Thanks for doing this but I'm going to do it slightly differently: #284