Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several bugs with nudge v1.1.2 #284

Merged
merged 9 commits into from
Nov 23, 2021
Merged

Fix several bugs with nudge v1.1.2 #284

merged 9 commits into from
Nov 23, 2021

Conversation

erikng
Copy link
Member

@erikng erikng commented Nov 22, 2021

@erikng erikng added the safe-to-test Allows a PR to be ran with the signing certificates label Nov 22, 2021
@erikng erikng changed the base branch from main to development November 22, 2021 19:54
@erikng erikng added safe-to-test Allows a PR to be ran with the signing certificates and removed safe-to-test Allows a PR to be ran with the signing certificates labels Nov 22, 2021
@erikng
Copy link
Member Author

erikng commented Nov 22, 2021

PR should now address #279 and #285 as well

@erikng erikng added safe-to-test Allows a PR to be ran with the signing certificates and removed safe-to-test Allows a PR to be ran with the signing certificates labels Nov 22, 2021
@erikng erikng added safe-to-test Allows a PR to be ran with the signing certificates and removed safe-to-test Allows a PR to be ran with the signing certificates labels Nov 22, 2021
@erikng erikng added safe-to-test Allows a PR to be ran with the signing certificates and removed safe-to-test Allows a PR to be ran with the signing certificates labels Nov 23, 2021
@erikng
Copy link
Member Author

erikng commented Nov 23, 2021

#273 is now fixed with this PR

@erikng
Copy link
Member Author

erikng commented Nov 23, 2021

PR now fixes #257

@erikng erikng changed the title Add logic for attemptToFetchMajorUpgrade and getBackupMajorUpgradeAppPath() Fix several bugs with nudge v1.1.2 Nov 23, 2021
@erikng erikng added safe-to-test Allows a PR to be ran with the signing certificates and removed safe-to-test Allows a PR to be ran with the signing certificates labels Nov 23, 2021
@erikng
Copy link
Member Author

erikng commented Nov 23, 2021

From @colorenz

I have successfully tested the following cases.

Test 0 😄
actionButtonPath set
Works

Test 1.
attemptToFetchMajorUpgrade -> false
majorUpgradeAppPath is set .../Downloads/Install\ macOS\ Monterey.app
Works ; Installer opens after a click on Update Device

Test 2.
attemptToFetchMajorUpgrade -> false
majorUpgradeAppPath is set not set
Installer is present in Applications (Backuppath)
Works ; Installer opens after a click on Update Device

Test 3.
attemptToFetchMajorUpgrade -> false
majorUpgradeAppPath is set not set
Installer is present in Applications (Backuppath)
Works ; Installer opens after a click on Update Device

Test 4.
attemptToFetchMajorUpgrade -> true
majorUpgradeAppPath is set not set
Installer is not present in Applications (Backuppath)
Update Defer 90 Days
Works; Nudge can not download Updates and exits.

Test 5.
attemptToFetchMajorUpgrade -> true
majorUpgradeAppPath is set not set
Installer is not present in Applications (Backuppath)
Update Defer 90 Days
Works; Nudge can not download Updates and exits.

Test 6.
attemptToFetchMajorUpgrade -> true
majorUpgradeAppPath is set not set
Installer is not present in Applications (Backuppath)
Update Defer 7 Days
Works; Nudge starts downloads the Update and starts

Test 7.
attemptToFetchMajorUpgrade -> true
majorUpgradeAppPath is set not set
Installer is present in Applications (Backuppath)
Update Defer 7 Days
Works; Nudge starts.

@erikng erikng merged commit de44e7a into development Nov 23, 2021
@erikng erikng deleted the major-upgrade-fixes branch November 29, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe-to-test Allows a PR to be ran with the signing certificates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant