Matrix Plotter #187
Merged
Matrix Plotter #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this  Use this action on your projects. Use jokes on issues instead. |
github-actions
bot
added
Plotting
dbarrow257
reviewed
Oct 28, 2024
mcmc/FitterBase.cpp
Outdated
| @@ -757,8 +717,7 @@ void FitterBase::RunLLHScan() { | |||
| //LLH scan is good first estimate of step scale | |||
| void FitterBase::GetStepScaleBasedOnLLHScan() { | |||
| // ************************* | |||
| TDirectory *Sample_LLH = (TDirectory*) outputFile->Get("Sample_LLH"); | |||
|
|
|||
| TDirectory *Sample_LLH = static_cast<TDirectory*>(outputFile->Get("Sample_LLH")); | |||
There was a problem hiding this comment.
Could use outputFile->Get("Sample_LLH") instead if you wanted
dbarrow257
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Move Matrix Plotter from T2K. This is example of plots using tutorial chain
https://github.com/mach3-software/MaCh3Tutorial/blob/3b0851a4fdb86000dc37ae1106cf0ac0db63342f/Tutorial/TutorialDiagConfig.yaml#L115C1-L127C4
Changes or fixes
Examples
MatrixPlot.pdf