Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented checkbox #24

Closed
wants to merge 5 commits into from
Closed

Implemented checkbox #24

wants to merge 5 commits into from

Conversation

bdlukaa
Copy link
Contributor

@bdlukaa bdlukaa commented Apr 15, 2021

No description provided.

@GroovinChip GroovinChip added the new widget Requests for new widgets label Apr 16, 2021
@GroovinChip GroovinChip self-requested a review April 17, 2021 16:10
@GroovinChip
Copy link
Collaborator

@bdlukaa pull the latest changes from dev

@GroovinChip GroovinChip linked an issue Apr 17, 2021 that may be closed by this pull request
Add checkbox widget #36
Closed
GroovinChip
GroovinChip requested changes Apr 17, 2021
View reviewed changes
lib/src/buttons/checkbox.dart Outdated Show resolved Hide resolved
lib/macos_ui.dart Show resolved Hide resolved
lib/src/buttons/checkbox.dart Show resolved Hide resolved
@GroovinChip GroovinChip self-requested a review April 18, 2021 14:22
GroovinChip
GroovinChip requested changes Apr 18, 2021
View reviewed changes
Copy link
Collaborator

@GroovinChip GroovinChip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkbox is not visible in light theme.
Screen Shot 2021-04-18 at 10 22 28 AM
Use the spec from the Figma kit to ensure the UI is correct in each theme
Screen Shot 2021-04-18 at 10 24 45 AM

@GroovinChip GroovinChip self-requested a review April 18, 2021 20:27
GroovinChip
GroovinChip requested changes Apr 18, 2021
View reviewed changes
example/pubspec.lock Outdated Show resolved Hide resolved
@GroovinChip GroovinChip self-requested a review April 19, 2021 00:28
GroovinChip
GroovinChip requested changes Apr 19, 2021
View reviewed changes
Copy link
Collaborator

@GroovinChip GroovinChip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really ought to get that gallery app off the ground so we stop running into conflicts in the example 😅

@bdlukaa Maybe it would be a good idea to consolidate this PR and #27 into one for easier conflict resolution?

@bdlukaa
Copy link
Contributor Author

bdlukaa commented Apr 19, 2021 •
edited by GroovinChip
Loading

@GroovinChip I think it's better to create a new pr, after this and the others get merged, with the example app updated

@bdlukaa oh, for sure. The gallery app can be done after these get merged. That said, I still think it's worth making a combined PR for checkbox and radio button to reduce conflicts

@bdlukaa bdlukaa mentioned this pull request Apr 19, 2021
Merged
5 tasks
@bdlukaa
Copy link
Contributor Author

bdlukaa commented Apr 19, 2021

Closing as duplicate of #47

@bdlukaa bdlukaa closed this Apr 19, 2021
@bdlukaa bdlukaa removed a link to an issue Apr 19, 2021
Add checkbox widget #36
Closed
@Maksimka101 Maksimka101 mentioned this pull request Mar 31, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GroovinChip GroovinChip GroovinChip requested changes

Assignees
No one assigned
Labels
new widget Requests for new widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdlukaa @GroovinChip