Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented RadioButton #27

Closed
wants to merge 5 commits into from
Closed

Implemented RadioButton #27

wants to merge 5 commits into from

Conversation

bdlukaa
Copy link
Contributor

@bdlukaa bdlukaa commented Apr 15, 2021

@GroovinChip GroovinChip added the new widget Requests for new widgets label Apr 16, 2021
@GroovinChip
Copy link
Collaborator

@bdlukaa pull the latest changes from dev

@GroovinChip GroovinChip linked an issue Apr 17, 2021 that may be closed by this pull request
Add RadioButton widget #37
Closed
@GroovinChip GroovinChip self-requested a review April 17, 2021 23:38
GroovinChip
GroovinChip requested changes Apr 17, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/buttons/radio_button.dart Outdated Show resolved Hide resolved
@GroovinChip
Copy link
Collaborator

Ensure dartfmt and optimize imports have been run on all changed files in addition to other requested changes.

@GroovinChip GroovinChip self-requested a review April 18, 2021 14:27
GroovinChip
GroovinChip requested changes Apr 18, 2021
View reviewed changes
Copy link
Collaborator

@GroovinChip GroovinChip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure unselected color is correct in light theme

Current:
Screen Shot 2021-04-18 at 10 31 39 AM

Spec:
Screen Shot 2021-04-18 at 10 31 49 AM
Screen Shot 2021-04-18 at 10 32 01 AM

GroovinChip
GroovinChip requested changes Apr 19, 2021
View reviewed changes
Copy link
Collaborator

@GroovinChip GroovinChip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review comments on #24 about merging PR's for easier conflict resolution

@bdlukaa bdlukaa mentioned this pull request Apr 19, 2021
Merged
5 tasks
@bdlukaa
Copy link
Contributor Author

bdlukaa commented Apr 19, 2021

Closing as duplicate of #47

@bdlukaa bdlukaa closed this Apr 19, 2021
@bdlukaa bdlukaa removed a link to an issue Apr 19, 2021
Add RadioButton widget #37
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GroovinChip GroovinChip GroovinChip requested changes

Assignees
No one assigned
Labels
new widget Requests for new widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdlukaa @GroovinChip