Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nvcc builds back from c++14 to c++17 #333

Closed
valassi opened this issue Jan 18, 2022 · 2 comments · Fixed by #354
Closed

Move nvcc builds back from c++14 to c++17 #333

valassi opened this issue Jan 18, 2022 · 2 comments · Fixed by #354
Assignees

Comments

@valassi
Copy link
Member

valassi commented Jan 18, 2022

Until today I had downgraded nvcc builds to c++14 (even if gccc builds use c++17), because I was using cuda 11.1 which does not support c++17.

I was using cuda 11.1 becuase of the performance regression (ggttgg slower by 20%) described in #282.

With the move to templated FFVs described in #328, a move back from cuda 11.1 to cuda 11.5 is possible (no performance regression, the code is actually faster!) and necessary (as otherwise the builds take too long).

I am therefore moving back to cuda 11.5. This supports c++17, so this move will allow reenabling c++17 builds in nvcc. I will do this AFTER merging #328.

The move from c++14 to c++17 will allow cleaning up the code in various places (eg in the MemoryAccessAmplitude variadic templates, and more).

@valassi
Copy link
Member Author

valassi commented Jan 18, 2022

I have even moved further from cuda11.5 to cuda11.6, released last week (#334)

@valassi
Copy link
Member Author

valassi commented Jan 26, 2022

This is completed in PR #354 that I am about to merge, can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant