WIP: a few fixes to use CXX=nvcc #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eep for compilation)
…nvcc Fails to link because of -pthread
Now the code builds and runs ok - all C++ code has been built with nvcc!
…vcc (with gcc102 below) Note that the printout still says gcc102, but this was built with export CXX=nvcc
…ler to detect if nvcc was used
…ter to avoid merge issues
|
Two more issues to fix, in total
|
|
Some of these points have been added in PR #354, but the main points of the PR are not (probably ar enot needed) |
|
Hi @valassi I'm only coming late to this PR. IIUC this is about building the C++/CPU code with nvcc? Or is it just to show that we could also use nvcc? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR related to #318.
I managed to build the code using 'export CXX=nvcc' and get good SIMD performance from the underlying gcc102.
So there should be no problem whatsoever building the SIMD C++ kernels using nvcc.
This is WIP because I still need to backport to code generation.