Fix JsHintReporter _builtInIgnoreRegex #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All '.' char in Regex require '\'.
madskristensen
added a commit
that referenced
this pull request
Feb 8, 2014
Fix JsHintReporter _builtInIgnoreRegex
|
Thanks!! And congrats on your first pull request :) |
|
Really happy to be accept so fast. ;) The next WE will have my contribution, used by lots of people. This is the first time I get into this! Thanks for all your awesome work! |
| @@ -56,19 +56,19 @@ public static bool ShouldIgnore(string file) | |||
| @"dojo\.js", | |||
| @"ember\.js", | |||
| @"ext-core\.js", | |||
| @"handlebars.*", | |||
| @"handlebars\.*", | |||
There was a problem hiding this comment.
Actually, this is wrong; \.* will only match repetitions of .s
|
Oops!!! My first contribute is totally wrong, due to my poor Regex! Should I revert it all back? Or whoever found problem will do it (just like what I do)? I don't know the common rule for resolving this. |
|
Just send a PR with the change |
|
@madskristensen This was fixed by #637 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time to contribute to open source project. Everything to me is new. Like GitHub, git, VS SDK. Even I'm not good at Regex too. If I do anything wrong, please forgive me.
I just looking for #603, found JSHint ignore rule mention by @SLaks.
All '.' char in Regex require ''.
I have tried to find a test case about this, but not exists. And I have no ability to create a new one. Hope this commit is right.