Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JsHintReporter _builtInIgnoreRegex #635

Merged
merged 1 commit into from
Feb 8, 2014
Merged

Fix JsHintReporter _builtInIgnoreRegex #635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions EditorExtensions/Commands/JavaScript/JsHintReporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,19 +56,19 @@ public static bool ShouldIgnore(string file)
@"dojo\.js",
@"ember\.js",
@"ext-core\.js",
@"handlebars.*",
@"handlebars\.*",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this is wrong; \.* will only match repetitions of .s

@"highlight\.js",
@"history\.js",
@"jquery-([0-9\.]+)\.js",
@"jquery.blockui.*",
@"jquery.validate.*",
@"jquery.unobtrusive.*",
@"jquery\.blockui\.*",
@"jquery\.validate\.*",
@"jquery\.unobtrusive\.*",
@"jquery-ui-([0-9\.]+)\.js",
@"json2\.js",
@"knockout-([0-9\.]+)\.js",
@"MicrosoftAjax([a-z]+)\.js",
@"modernizr-([0-9\.]+)\.js",
@"mustache.*",
@"mustache\.*",
@"prototype\.js ",
@"qunit-([0-9a-z\.]+)\.js",
@"require\.js",
Expand Down