Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Rating & Review #186

Merged
merged 22 commits into from
Jan 16, 2017
Merged

Application Rating & Review #186

merged 22 commits into from
Jan 16, 2017

Conversation

ouranos
Copy link
Contributor

@ouranos ouranos commented Jan 12, 2017

@alexnoox could you look at the last commit?

I've added a feature flag and updated the Admin Panel to use it.

Full sanity check of the PR would be good too :)

@ouranos ouranos self-assigned this Jan 12, 2017
@ouranos ouranos requested review from alexnoox and x4d3 January 12, 2017 05:31
json.categories @categories
json.apps @apps, partial: 'app', as: :app
end
json.categories @categories
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll do some perf analysis to see the impact of removing the cache

Copy link
Contributor

@alexnoox alexnoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@app_review = MnoEnterprise::AppReview.find(params[:id])
end


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove an empty line.

@ouranos ouranos merged commit 0137648 into 3.2 Jan 16, 2017
@ouranos ouranos deleted the feature/app-rating branch February 3, 2017 00:50
aluqueGH pushed a commit to aluqueGH/mno-enterprise that referenced this pull request Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants